Uh oh!
There was an error while loading. Please reload this page.
Publish without node-pty dependency - #585
Merged
Merged
Conversation
Christof Marti (chrmarti)force-pushed
the
chrmarti/familiar-chicken
branch
2 times, most recently
from
July 4, 2023 13:10
dd65fec to
9cc516fCompareChristof Marti (chrmarti)force-pushed
the
chrmarti/familiar-chicken
branch
from
July 12, 2023 08:35
04065df to
1b0bcc2CompareChristof Marti (chrmarti)force-pushed
the
chrmarti/familiar-chicken
branch
from
July 12, 2023 08:38
1b0bcc2 to
1161f39CompareChristof Marti (chrmarti)
marked this pull request as ready for review
July 13, 2023 12:33
joshspicer
approved these changes
Jul 13, 2023
joshspicer
left a comment
Member
There was a problem hiding this comment.
LGTM - I think this will require some extra testing in Codespaces once published. Do you anticipate any other changes we'll need to make to pick this up?
Christof Marti (chrmarti)
commented
Jul 13, 2023
ContributorAuthor
joshspicer From what I saw you install |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-remote-release#8698