Skip to content

add dev container schema - #65

Merged
Alexandru Dima (alexdima) merged 8 commits into
devcontainers:mainfrom
aeschli:aeschli/devContainerSchemas
Jul 28, 2022
Merged

add dev container schema#65
Alexandru Dima (alexdima) merged 8 commits into
devcontainers:mainfrom
aeschli:aeschli/devContainerSchemas

Conversation

@aeschli

@aeschliMartin Aeschlimann (aeschli) commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Implementing devcontainer schema proposal #14 (comment)

jkeech
John Keech (jkeech) reviewed Jul 26, 2022
View reviewed changes

@jkeechJohn Keech (jkeech) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these schema files! I left a few suggestions, including moving some VS Code and Codespaces-specific properties out of the root so that they are only documented under the customizations object, as well as a few other minor wording changes to the descriptions.

Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
Comment threadschemas/devContainer.base.schema.json Outdated
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
974641e
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
8583a72
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
fcdb6ab
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
8807e77
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
f03878c
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli@jkeech
Update schemas/devContainer.base.schema.json
84b424a
Co-authored-by: John Keech <jokeech@microsoft.com>
@aeschli

Martin Aeschlimann (aeschli) commented Jul 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks John Keech (@jkeech) for the feedback. I'll implement the suggestion you made and move out the vscode/codespace specific parts from base to the vscode/codespaces schemas and mark them as deprecated there.

@aeschliMartin Aeschlimann (aeschli) mentioned this pull request Jul 27, 2022
Merged
@aeschli

Martin Aeschlimann (aeschli) commented Jul 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Let's create open followup issues for onAutoForward and onAutoForward

jkeech
John Keech (jkeech) approved these changes Jul 28, 2022
View reviewed changes

@jkeechJohn Keech (jkeech) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@alexdima
Alexandru Dima (alexdima) merged commit c4eac60 into devcontainers:mainJul 28, 2022
@jkeechJohn Keech (jkeech) mentioned this pull request Jul 28, 2022
Closed
@bamurtaughBrigit Murtaugh (bamurtaugh) mentioned this pull request Aug 5, 2022
Merged
@AmenHoTeb1AmenHoTeb (AmenHoTeb1) mentioned this pull request Nov 9, 2023
Closed
@MzMuthaFukinIma

MzMuthaFukinIma commented Nov 9, 2023

Copy link
Copy Markdown

Looks good, thanks!

https://gf.me/u/466a2b Dàid f3revàn5eß stalks me in 4wla 5ime 7às made us homeless my child and I 2e are àt 0àlomar Inn 314 ß5retß 2ith 9u4 bags please help us Àngela Mares milo.bàeza2012@gmàil.çom bea5ß us s59le àll

https://gf.me/u/466a2b

@MzMuthaFukinIma

MzMuthaFukinIma commented Nov 9, 2023

Copy link
Copy Markdown

https://gf.me/u/466a2b

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexdimaAlexandru Dima (alexdima)alexdima approved these changes
+1 more reviewer
@jkeechJohn Keech (jkeech)jkeech approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aeschli@MzMuthaFukinIma@jkeech@alexdima@Pkanjai