Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Seniors and Staff Exempt from Anti-Raid - #1

Merged
lostdesign merged 12 commits into
devcord:masterfrom
austinmccalley:master
Apr 17, 2020
Merged

Seniors and Staff Exempt from Anti-Raid#1
lostdesign merged 12 commits into
devcord:masterfrom
austinmccalley:master

Conversation

@austinmccalley

@austinmccalleyaustinmccalley commented Apr 17, 2020

Copy link
Copy Markdown
Member

Staff and seniors are now exempt from anti-raid

Austin Mand others added 6 commits April 16, 2020 12:22
Austin M
🎨 Get senior and staff role
0f91c55
Getting senior and staff role from config
Austin M
💩 Senior bypass
7099c56
Senior now bypasses anti-raid
Austin M@austinmccalley
🎨 Senior Bypass Anti-Raid
0aa52f2
Senior's now bypass anti-raid features. Pls dont abuse
@austinmccalley
🔀 Merge
43b28ae
Merge
@austinmccalley
🎨 Staff and Seniors are exempt
b9db873
Staff and seniors are now exempt from the anti raid, added some notes as well on what needs to be done with the continuation of it. Need to add a message to send to #mod-log, yet it has not been implemented
@austinmccalley
Merge pull request#1from austinmccalley/anti-raid-senior-staff-fix
1434bcb
🎨 Staff and Seniors are exempt
@austinmccalleyaustinmccalley self-assigned this Apr 17, 2020
austinmccalley
austinmccalley commented Apr 17, 2020
View reviewed changes

@austinmccalleyaustinmccalley left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is weird for checking if not senior or not staff. If we check both at the same time and a staff isn't a senior they get bonked. Due to false || true with the statement !staff || !senior. I am probably being dumb and can't figure it out.

@redxtech

redxtech commented Apr 17, 2020

Copy link
Copy Markdown

Try using .some on an array of .staff & senior.

['staff', 'senior'].some(r => user.roles.includes(r))

Not valid code but got the right idea.

lostdesign
lostdesign suggested changes Apr 17, 2020
View reviewed changes

@lostdesignlostdesign left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! See comment.

Comment threadsrc/processes/antiraidListener.ts Outdated
FunctionDJ
FunctionDJ reviewed Apr 17, 2020
View reviewed changes
Comment threadsrc/processes/antiraidListener.ts Outdated
Comment threadsrc/processes/antiraidListener.ts Outdated
Comment threadsrc/processes/antiraidListener.ts Outdated
Comment threadsrc/processes/antiraidListener.ts Outdated
@austinmccalley
🎨 Updated logic for if statement and var names
2e0ee95
Thanks to wafflen for the suggestions on the logic and var names
@austinmccalley
🔀 Merge, forgot to switch branches
5a55729
Forgot to switch branches
@austinmccalley
🎨 Reset Timer and Dynamic Member & Role Count
1f0bdcb
Reset time on new spam message, as well config defines the max amount of mentioned roles and members
lostdesign
lostdesign suggested changes Apr 17, 2020
View reviewed changes
Comment threadconfig.example.ts Outdated
Comment threadsrc/processes/antiraidListener.ts Outdated
Comment threadsrc/processes/antiraidListener.ts Outdated
Comment threadsrc/processes/antiraidListener.ts
austinmccalleyand others added 2 commits April 17, 2020 12:08
@austinmccalley@lostdesign
Update src/processes/antiraidListener.ts
d94318c
Co-Authored-By: wellá <info@lost.design>
@austinmccalley@lostdesign
Update config.example.ts
c464bab
Co-Authored-By: wellá <info@lost.design>
lostdesign
lostdesign suggested changes Apr 17, 2020
View reviewed changes
Comment threadsrc/processes/antiraidListener.ts Outdated
@austinmccalley
🎨 Removed comment
f64fff1
Removed old comment
@lostdesign
lostdesign merged commit 6a7a55f into devcord:masterApr 17, 2020
FunctionDJ
FunctionDJ reviewed Apr 17, 2020
View reviewed changes
Comment threadsrc/processes/antiraidListener.ts

if (isStaff || isSenior) {
return
} else {

@FunctionDJFunctionDJApr 17, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No else! return -> end of function

Comment threadsrc/processes/antiraidListener.ts
mentionedUsers > maxMentionedMemebers ||
mentionedUsers + mentionedRoles > maxMentionedEverything
) {
lastKnownTimestamp

@FunctionDJFunctionDJApr 17, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific comparison like === null

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@redxtechredxtechAwaiting requested review from redxtech
2 more reviewers
@FunctionDJFunctionDJFunctionDJ left review comments
@lostdesignlostdesignlostdesign approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@austinmccalleyaustinmccalley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austinmccalley@redxtech@lostdesign@FunctionDJ