[draft] Use Babel to transpile JSX instead of TypeScript - #573
Merged
Conversation
ForsakenHarmony
approved these changes
Mar 3, 2020
developit
marked this pull request as ready for review
March 6, 2020 19:31
developit
commented
Mar 6, 2020
OwnerAuthor
I need to add tests. |
ForsakenHarmony
commented
Mar 12, 2020
Collaborator
bors try |
Contributor
tryBuild failed |
ForsakenHarmony
commented
Mar 12, 2020
Collaborator
oh, we have a lockfile now 🙃 |
ForsakenHarmony
commented
Jul 21, 2020
Collaborator
bors r+ |
borsBot
pushed a commit
that referenced
this pull request
Jul 21, 2020
It seems like we're allowing TypeScript to transpile JSX, when we could be allowing Babel to do so. Having TypeScript pass-through JSX to babel would mean we only have to support it being configurable in one place. (hoping this fixes#564) Co-authored-by: Leah <me@hrmny.sh> Co-authored-by: Leah <github.leah@hrmny.sh>
Contributor
Timed out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like we're allowing TypeScript to transpile JSX, when we could be allowing Babel to do so. Having TypeScript pass-through JSX to babel would mean we only have to support it being configurable in one place.
(hoping this fixes#564)