Skip to content

Add worker-loader - #815

Closed
TimDaub wants to merge 9 commits into
developit:masterfrom
TimDaub:feat/syntax-worker-detection
Closed

Add worker-loader#815
TimDaub wants to merge 9 commits into
developit:masterfrom
TimDaub:feat/syntax-worker-detection

Conversation

@TimDaub

@TimDaubTimDaub commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Few comments

🤞🏼 that somehow this gets merged!

@schlusslicht@TimDaub
Add worker-loader
1e4d012
Targets enhancement: developit#170
Enable usage of `microbundle --worker-loader` to apply rollup-plugin-web-worker-loader.
Allow bundling web workers automatically
- Add flag `--worker-loader`
- For format `es` and `modern`, a Worker `type: module` is automatically
bundled
@changeset-bot

changeset-botBot commented Mar 4, 2021•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f155eee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimDaubTimDaub mentioned this pull request Mar 4, 2021
Open
developit
developit reviewed May 5, 2021
View reviewed changes
Comment threadREADME.md Outdated
Comment threadsrc/index.js Outdated
Comment threadsrc/prog.js Outdated
Comment threadtest/__snapshots__/index.test.js.snap Outdated
Comment threadtest/__snapshots__/index.test.js.snap Outdated
Comment threadtest/fixtures/worker-loader/package.json Outdated
developit
developit reviewed May 5, 2021
View reviewed changes
Comment threadREADME.md Outdated
TimDauband others added 8 commits May 5, 2021 19:07
@TimDaub@developit
Update README.md
fa349a1
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub@developit
Update src/index.js
5d3a32a
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub@developit
Update src/prog.js
ebdba42
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub@developit
Update test/__snapshots__/index.test.js.snap
6f8275d
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub@developit
Update test/fixtures/worker-loader/package.json
8a89350
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub@developit
Update README.md
1ccfbd0
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
@TimDaub
Make eslint pass
87ba7a0
@TimDaub
Remove node_modules from snapshot
f155eee
@TimDaub
TimDaub requested a review from developitMay 5, 2021 20:16
@TimDaub

TimDaub commented May 5, 2021

Copy link
Copy Markdown
ContributorAuthor

@developit I addressed your comments. I'm not sure I'm capable of rebasing though. Last time I tried sketchy things happened in package-lock.json that I wasn't able to address. What now?

@ForsakenHarmony

ForsakenHarmony commented May 26, 2021

Copy link
Copy Markdown
Collaborator

Last time I tried sketchy things happened in package-lock.json that I wasn't able to address.

You generally have to accept the remote one and then after create a new commit / amend a commit with a file you generated after by running npm install

@developit

developit commented May 27, 2021

Copy link
Copy Markdown
Owner

I'll try to get this rebased this week (I'm also terrible at it!).

This will need to go into a new breaking release (minor since microbundle is still pre-1.0), but I think that should be fine.

@developit

developit commented Jun 7, 2021

Copy link
Copy Markdown
Owner

Just wanted to mention I haven't forgotten about this PR, I just have been side-tracked rewriting Microbundle's filename inference.

@marcbouchenoiremarcbouchenoire mentioned this pull request Jul 20, 2021
Merged
@developit

developit commented Oct 6, 2021

Copy link
Copy Markdown
Owner

This was landed in #867! 🎉

@developitdevelopit mentioned this pull request Oct 6, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developitdevelopitdevelopit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scriptURL of serviceWorker.register isn't considered part of bundle

4 participants

@TimDaub@ForsakenHarmony@developit@schlusslicht