Skip to content

Fix: preserve terser annotations regexp - #875

Merged
developit merged 3 commits into
developit:masterfrom
dwightjack:fix/terser-comment-regexp
Oct 6, 2021
Merged

Fix: preserve terser annotations regexp#875
developit merged 3 commits into
developit:masterfrom
dwightjack:fix/terser-comment-regexp

Conversation

@dwightjack

Copy link
Copy Markdown
Contributor

Related to #871.

This PR fixes the regexp that preserves terser annotations in bundles.

@changeset-bot

changeset-botBot commented Aug 8, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d3ffb59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
microbundlePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@developitdevelopit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! What a silly mistake on my part - thanks for catching this.

@developit

Copy link
Copy Markdown
Owner

Test failures all seem to be due to output for TS CJS/UMD bundles now marking require().default as /*#__PURE__*/. Seems a bit explicit, but I don't think there's a TS option that turns off insertion just for default imports.

@dwightjack

Copy link
Copy Markdown
ContributorAuthor

@developit I am not sure about the action required to fix the CI issue. Is it fine to update the snapshot, or should I do something else?

@developit

Copy link
Copy Markdown
Owner

@dwightjack updating the snapshot would be a good first step, yep. We can review the changes individually then.

@dwightjack

Copy link
Copy Markdown
ContributorAuthor

@developit Thanks! I've updated the snapshot. Changes included terser annotations and bundle size change (increased, I guess, because of the annotations).

@developit
developit merged commit 5d0465b into developit:masterOct 6, 2021
@preact-botpreact-bot mentioned this pull request Oct 6, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dwightjack@developit