Skip to content

feat: ✨ Closes #497: preserve trailing newline in mangle.json#882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 5 commits into from
Oct 14, 2021
Merged

feat: ✨ Closes #497: preserve trailing newline in mangle.json #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31f7a7d
feat: :sparkles: Closes #497: preserve trailing newline in mangle.json
mikr13 Aug 22, 2021
5ef91d6
chore: :rewind: package-lock.json reset to origin version
mikr13 Aug 22, 2021
1ff3daa
fix: :bug: platform independent EOL fixes
mikr13 Aug 25, 2021
93b06ee
Update .editorconfig
ForsakenHarmony Oct 14, 2021
5a86e27
Create quick-wasps-itch.md
ForsakenHarmony Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-wasps-itch.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"microbundle": patch
---

feat: :sparkles: Closes #497: preserve trailing newline in mangle.json
13 changes: 11 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
} from './lib/option-normalization';
import { getConfigFromPkgJson, getName } from './lib/package-info';
import { shouldCssModules, cssModulesConfig } from './lib/css-modules';
import { EOL } from 'os';

// Extensions to use when resolving modules
const EXTENSIONS = ['.ts', '.tsx', '.js', '.jsx', '.es6', '.es', '.mjs'];
Expand DownExpand Up@@ -397,9 +398,13 @@ function createConfig(options, entry, format, writeMeta) {
const externalTest =
external.length === 0 ? id => false : id => externalPredicate.test(id);

let endsWithNewLine = false;

function loadNameCache() {
try {
nameCache = JSON.parse(fs.readFileSync(getNameCachePath(), 'utf8'));
const data = fs.readFileSync(getNameCachePath(), 'utf8');
endsWithNewLine = data.endsWith(EOL);
nameCache = JSON.parse(data);
// mangle.json can contain a "minify" field, same format as the pkg.mangle:
if (nameCache.minify) {
minifyOptions = Object.assign(
Expand DownExpand Up@@ -609,7 +614,11 @@ function createConfig(options, entry, format, writeMeta) {
if (writeMeta && nameCache) {
fs.writeFile(
getNameCachePath(),
JSON.stringify(nameCache, null, 2),
JSON.stringify(
endsWithNewLine ? `${nameCache}${EOL}` : nameCache,
null,
2,
),
() => {},
);
}
Expand Down