Skip to content

fix: tsconfig cwd differing from microbundle's cwd - #941

Merged
rschristian merged 2 commits into
masterfrom
fix/tsconfig-cwd
Apr 20, 2022
Merged

fix: tsconfig cwd differing from microbundle's cwd#941
rschristian merged 2 commits into
masterfrom
fix/tsconfig-cwd

Conversation

@rschristian

@rschristianrschristian commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator

Closes#939

Simply ensures the TS plugin will begin its search for a tsconfig.json in the specified --cwd.

This is not a breaking change; in the case of a tsconfig.json only existing higher in a project structure, and not in the passed --cwd, rpt2 (which makes use of typescript itself, actually) will ascend the file tree attempting to discover a config file.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e981289

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
microbundlePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@developitdevelopit left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@rschristianrschristian changed the title Fix/tsconfig cwdfix: tsconfig cwd differing from microbundle's cwdApr 18, 2022
@rschristian
rschristian merged commit 1d0e305 into masterApr 20, 2022
@rschristian
rschristian deleted the fix/tsconfig-cwd branch April 20, 2022 20:15
@preact-botpreact-bot mentioned this pull request Apr 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--cwd and --tsconfig

2 participants

@rschristian@developit