Skip to content

(chore) Add support for preact x - #48

Open
cristianbote wants to merge 14 commits into
developit:masterfrom
cristianbote:chore/add-support-for-preact-x
Open

(chore) Add support for preact x#48
cristianbote wants to merge 14 commits into
developit:masterfrom
cristianbote:chore/add-support-for-preact-x

Conversation

@cristianbote

@cristianbotecristianbote commented Aug 28, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator

This adds support for preact x but depends on this PR from preactpreactjs/preact#1901. After that's merged and released we could merge this one as well.

Adds +3.71kB 😞 more than double it's current size
Adds +0.89kB 😄 now we're talking
Adds +0.98kB 🤔

@cristianbote

cristianbote commented Aug 28, 2019

Copy link
Copy Markdown
CollaboratorAuthor

This will fail until preactjs/preact#1901 is merged

@cristianbote

cristianbote commented Sep 10, 2019

Copy link
Copy Markdown
CollaboratorAuthor

This is gonna be working when preactjs/preact#1924 it's gonna get released

@cristianbote

cristianbote commented Oct 3, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Also this updates the react-redux version and redux with the latest ones.

developit
developit reviewed Oct 7, 2019
View reviewed changes
Comment threadpackage.json Outdated
developit
developit reviewed Oct 7, 2019
View reviewed changes
Comment threadrollup.config.js Outdated
developit
developit reviewed Oct 7, 2019
View reviewed changes
Comment threadsrc/compat.js Outdated
@developit

developit commented Oct 7, 2019

Copy link
Copy Markdown
Owner

Folks will be glad to have this working in X. One question still in my mind though: do we know why aliasing react:preact doesn't work, instead requiring all of compat? I'd really love to quantify that delta.

@cristianbote@developit
Apply suggestions from code review
7e5cb57
Awesome pointers!
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
@cristianbote

cristianbote commented Oct 7, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Hey @developit that's a great point! Unfortunately it seems that the build size increases if I would add the imports by hand and re-export them. 🤷‍♂

@fjorgemotafjorgemota mentioned this pull request Jan 20, 2020
Open
@jahilldev

jahilldev commented Jan 31, 2020

Copy link
Copy Markdown

@cristianbote@marvinhagemeister Any ideas on when this might be released? Would really like to upgrade to Preact X.

Many thanks

@cristianbote

cristianbote commented Jan 31, 2020

Copy link
Copy Markdown
CollaboratorAuthor

@jhdevuk it's awaiting Jason's review. It's on his todo list 👍

bdombro
bdombro reviewed Apr 30, 2021
View reviewed changes
Comment threadrollup.config.js

let external = Object.keys(pkg.peerDependencies || {}).concat(
Object.keys(pkg.dependencies || {})
Object.keys(pkg.dependencies || {}), 'preact/compat'

@bdombrobdombroApr 30, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including preact/compat completely defeats the purpose of this project, doesn't it? 😿

@adminy

adminy commented Dec 9, 2021•
edited
Loading

Copy link
Copy Markdown

Ok, well, what are the alternatives? Where to get Provider and connect from?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developitdevelopitAwaiting requested review from developit
2 more reviewers
@bdombrobdombrobdombro left review comments
@marvinhagemeistermarvinhagemeistermarvinhagemeister approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cristianbote@developit@jahilldev@adminy@marvinhagemeister@bdombro