Ensure tags must fit pattern before adding them - #21
Open
mikemaccana wants to merge 20 commits into
Open
Conversation
developit
self-requested a review
April 10, 2017 13:44
developit
approved these changes
Apr 10, 2017
thomasdegry
commented
May 16, 2017
@developit any reason why we can't merge this yet? Would be awesome to have this functionality working! |
developit
commented
May 16, 2017
Owner
|
developit
requested changes
May 16, 2017
| // Add multiple tags if the user pastes in data with SEPERATOR already in it | ||
| if (~text.indexOf(SEPERATOR)) text = text.split(SEPERATOR); | ||
| if (Array.isArray(text)) return text.forEach(addTag); | ||
| if ( text.includes(SEPERATOR) ) { |
There was a problem hiding this comment.
seems a shame to give up IE compat here
mikemaccana
commented
May 17, 2017
ContributorAuthor
We could just add a polyfill for legacy browsers. This keeps the code clean and can be deleted quickly when you finally drop IE. :^) |
developit
commented
May 21, 2017
Owner
I'm too obsessed with file size to go that route 😜 |
mikemaccana
commented
May 22, 2017
ContributorAuthor
Developit: it's literally only a few characters See https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/includes . It's also way more readable than ye olde "if index is greater than or equal to zero". |
added 17 commits
August 17, 2017 14:23
…s of module can pick their own build tools) Make index.js just an npm module. Nobody cares about UMD, AMD, or TC39 modules.
Fix 'base' and just use document
Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#20