Fix Typescript export definitions - #116
Open
vincentcr wants to merge 2 commits into
Open
Conversation
Typescript does not support .mjs file, so the module that ends up being imported is the commonJS version (`dist/unfetch.js`). Since it does not contain a "default" export entry, using it in Typescript results in a runtime error: `TypeError: isomorphic_unfetch_1.default is not a function` Fix by reverting to `export =`. To use in Typescript, use the form `import * as fetch from "isomorphic-unfetch"`.
shevchenkonik
commented
Jun 18, 2019
Yes, I have similar problem and this PR will solve it. Thanks @vincentcr |
developit
commented
Feb 18, 2020
Owner
I believe this should be addressed by #135, which drops the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript does not support .mjs files, so the module that ends up being imported is the commonJS version (
dist/unfetch.js). Since that file does not contain adefaultexport entry, using it in Typescript results in a runtime error:TypeError: isomorphic_unfetch_1.default is not a functionFix by reverting to
export =. To use in Typescript, use the formimport * as fetch from "isomorphic-unfetch".