Remove node-fetch dependency for unfetch TS definition file - #98
Open
1999 wants to merge 4 commits into
Open
Conversation
AnselmMarie
commented
Nov 30, 2019
Is there an update on this PR? |
developit
commented
Feb 18, 2020
Owner
1999
commented
Feb 25, 2020
Author
Yep, these changes look not related. Should be fine. |
developit
commented
Sep 29, 2020
Owner
I still need to check if this is correct. We landed #117 but I don't have a TypeScript project to test things out in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a chat in #96 I decided to remove the
node-fetchimports fromunfetchdefinition file as now it produces TS compiler errors.isomorphic-unfetchdefinion stayed untouched.