Standardize on obstore's NotFoundError

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.

[kylebarron]

Closes#197

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

[kylebarron]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

[ion-elgreco]

Also fine with keeping the Py FileNotFoundError, I think in delta-rs we also raise that one instead of a custom exception

I'm debating this too... I'm leaning towards using the obstore.exceptions.NotFoundError so that it can subclass from a common base exception from obstore.exceptions?

That might be better if you want to handle exceptions across obstore with the base exception.

[kylebarron]

@martindurant How can we tell fsspec a list of allowed exceptions? Switching from FileNotFoundError to obstore.exceptions.NotFoundError is breaking the fsspec integration

[martindurant]

Simplest would be to subclass

[kylebarron]

I think one possible solution here (without having to subclass fsspec) is to make NotFoundError subclass from both BaseError and FileNotFoundError. However, it's unclear if multiple inheritance is possible in pyo3.