chore (deps) : bump controller-runtime to v0.18.7

[rohanKanojia]

What does this PR do?

Bump controller-runtime dependency to v0.18.7

There are lots of changes in controller-runtime since last upgrade. They're listed below:

• Port removed from controller Options, we now have to create a separate WebhookServer object and add it to manager

• Add new argument ctx.Context in Watch handler method

• source.Kind not available in latest versions anymore, use directly type instead in Watch()

• MetricsBindAddress no longer available in controller Options, use Metrics object instead.

• cache.SelectorsByObject no longer present in cache package, users are advised to use ByObject inside cache Options instead

• cache.BuilderWithOptions no longer present in controller-runtime, use inline method in return instead.

• fake.NewFakeClientWithScheme not available anymore, use fake.NewClientBuilder() instead

• Replace corev1.ResourceRequirements with corev1.VolumeResourceRequirements

• Specify finalizers in finalize_test wherever DeletionTimestamp is provided to avoid error thrown by test for missing finalizers

• admission.Decoder is an interface now, previously it was a concrete type.

• The runtime injection functionality has been deprecated since Controller Runtime 0.10; all of the above fields can be passed from the Manager to structs or interfaces that need them.

Signed-off-by: Rohan Kumar rohaan@redhat.com

What issues does this PR fix or reference?

Related to #1343

Is it tested? How?

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 29.09091% with 39 lines in your changes missing coverage. Please review.

Project coverage is 39.61%. Comparing base (efb5ad6) to head (4d146d8).

Files with missing lines	Patch %	Lines
webhook/main.go	0.00%	15 Missing ⚠️
pkg/cache/cache.go	40.00%	9 Missing ⚠️
main.go	0.00%	7 Missing ⚠️
webhook/workspace/config.go	0.00%	3 Missing ⚠️
...ollers/cleanupcronjob/cleanupcronjob_controller.go	0.00%	2 Missing ⚠️
controllers/workspace/devworkspace_controller.go	85.71%	0 Missing and 1 partial ⚠️
webhook/workspace/mutate.go	0.00%	1 Missing ⚠️
webhook/workspace/validate.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1435 +/- ##
==========================================
- Coverage 39.66% 39.61% -0.06% 
==========================================
Files 160 160 Lines 13139 13143 +4 ==========================================
- Hits 5211 5206 -5 - Misses 7551 7560 +9 
Partials 377 377 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[rohanKanojia]

/ok-to-test

[dkwon17]

I've accumulated the breaking changes from controller-runtime v0.15.0 to v0.18.0 to help me review this PR: https://gist.github.com/dkwon17/8fd9a8e280ef8b30eedbff6fb345bbbb

So far, I have tested:

• Mounting secrets/configmaps
• Webhook server works
  • tested by exec-ing into devworksapce pod
  • tested by creating a web terminal pod
• Tested project cloning and devfile commands from https://github.com/che-incubator/quarkus-api-example
• Deleting all workspaces deletes the per-user-claim
• Check if per-user PVC is recreated when it is deleted

[dkwon17]

Could we delete this comment?

 // Annoying quirk: cache.SelectorsByObject uses an internal struct for values (internal.Selector)
// so we _can't_ just add Routes here since we cannot initialize the corresponding value.

[rohanKanojia]

This comment was added in this PR #652

I'll remove it in next update.

[rohanKanojia]

CI is failing due to go build requiring go 1.24 #12 0.112 go: go.mod requires go >= 1.24.0 (running go 1.23.9; GOTOOLCHAIN=local)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dkwon17]

I've tested that resource caching is working by creating many automount configmaps, with and without the watch-configmap label and observing the memory usage of the devworkspace-controller pod.

Thank you @rohanKanojia , could you please squash and merge this PR?