Uh oh!
There was an error while loading. Please reload this page.
fix: restrict external DevWorkspaceOperatorConfig references to allowed namespaces - #1696
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0932bf2 to
5e6617aCompareCodecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1696 +/- ##
==========================================
+ Coverage 40.46% 40.56% +0.09%
==========================================
Files 172 172 Lines 15634 15674 +40 ==========================================
+ Hits 6327 6358 +31 - Misses 8920 8926 +6 - Partials 387 390 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7738161 to
e6d461cCompare…ed namespaces Workspace-local operator configs continue to override operational settings, while pod-level fields are taken only from configs in the operator namespace. Assisted-by: Cursor Grok 4.6 Signed-off-by: Rohan Kumar <rohaan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
619d297 to
a5e4fdcCompare
What does this PR do?
Limits
controller.devfile.io/devworkspace-configso a DevWorkspace can only reference aDevWorkspaceOperatorConfigin its own namespace or the operator namespace.Workspace-local DWOCs still merge operational settings (for example
imagePullPolicyand PVC name). Pod-level fields such as security context, service account, runtime class, default template, pod annotations, and scheduler name are applied only when the referenced DWOC is in the operator namespace.What issues does this PR fix or reference?
N/A
Is it tested? How?
TODO: Will share a test plan soon
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che