Skip to content

feat: Add attribute to allow specifyin deployment labels/annotations - #793

Merged
amisevsk merged 2 commits into
devfile:mainfrom
amisevsk:deploy-labels-annotations
Mar 17, 2022
Merged

feat: Add attribute to allow specifyin deployment labels/annotations#793
amisevsk merged 2 commits into
devfile:mainfrom
amisevsk:deploy-labels-annotations

Conversation

@amisevsk

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add attributes controller.devfile.io/deployment-labels and controller.devfile.io/deployment-annotations which can be used to specify labels and annotations to be applied to the workspace deployment

What issues does this PR fix or reference?

Closes#698

Is it tested? How?

To test, apply the DevWorkspace

cat <<EOF | kubectl apply -f -apiVersion: workspace.devfile.io/v1alpha2kind: DevWorkspacemetadata:
name: plainspec:
routingClass: basicstarted: truetemplate:
attributes:
controller.devfile.io/storage-type: ephemeralcontroller.devfile.io/deployment-labels: my-label: foomy-other-label: barcontroller.devfile.io/deployment-annotations: my-attribute: foomy-other-attribute: barcomponents:
- container:
command:
- tail
- -f
- /dev/nullimage: quay.io/amisevsk/web-terminal-tooling:devmemoryLimit: 512MimountSources: truename: web-terminalEOF

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Add attributes
* controller.devfile.io/deployment-labels
* controller.devfile.io/deployment-annotations
to allow specifying labels and annotations that should be applied to the
DevWorkspace deployment.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk
amisevsk merged commit 01e0e27 into devfile:mainMar 17, 2022
@amisevsk
amisevsk deleted the deploy-labels-annotations branch March 17, 2022 16:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to specify annotation/labels for the Workspace

2 participants

@amisevsk@ibuziuk