Don't count terminating workspaces when checking shared PVC count

[amisevsk]

What does this PR do?

Skips counting terminating workspaces when checking if we can delete the common PVC. This avoids running the cleanup job for each workspaces when running e.g. kubectl delete dw --all.

What issues does this PR fix or reference?

Closes#857

Is it tested? How?

Can be tested via the script from the issue:

foriin {1..5};do
yq --arg i "$i"'.metadata.name="theia-next-\($i)"' samples/theia-next.yaml | kubectl apply -f -
sleep 2s
kubectl patch dw "theia-next-$i" --type merge -p '{"spec": {"started": false}}'done
kubectl delete dw --all --wait=false && kubectl get jobs -w

no jobs should be created.

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[AObuchow]

Code looks good & tested and verified the patch works as expected :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow, dkwon17, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment