Skip to content

Fix issue where deleting a workspace deletes the PVC incorrectly#870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amisevsk merged 1 commit into from
Jun 16, 2022
Merged

Fix issue where deleting a workspace deletes the PVC incorrectly #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/provision/storage/commonStorage.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -94,7 +94,7 @@ func (p *CommonStorageProvisioner) CleanupWorkspaceStorage(workspace *dw.DevWork

// If the number of common + async workspaces that exist (started or stopped) is zero,
// delete common PVC instead of running cleanup job
if totalWorkspaces > 1 {
if totalWorkspaces > 0 {
return runCommonPVCCleanupJob(workspace, clusterAPI)
} else {
sharedPVC := &corev1.PersistentVolumeClaim{}
Expand Down