Uh oh!
There was an error while loading. Please reload this page.
Block 'run' and 'debug' makefile rules if controller is not scaled to 0 - #883
Merged
Merged
Conversation
In order to prevent potentially confusing errors, block running the controller locally if the in-cluster deployment is not scaled to 0. This is necessary as running two instances of the controller can result in conflicting reconcile outputs, causing each instance to compete against the other. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Blocks using
make runandmake debugif the controller is still running in cluster.What issues does this PR fix or reference?
Avoids issues like #879 (comment)
Is it tested? How?
make install)make runandmake debugcommands. Should exit withoc scale deploy devworkspace-controller-manager -n $NAMESPACE --replicas=0make runandmake debugwork as normal.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che