Uh oh!
There was an error while loading. Please reload this page.
Fixes - #10
Merged
Merged
Conversation
Composer package changes
|
There was a problem hiding this comment.
Pull request overview
This PR modernizes the library’s type signatures and dependency requirements by upgrading to PSR v2/v3 packages and raising the minimum supported PHP version, with corresponding lockfile updates.
Changes:
- Bump runtime requirements to PHP
^8.3,psr/log^3.0, andpsr/container^2.0. - Update
QueueContainerandLoggermethod signatures to use stricter parameter/return types aligned with the newer PSR packages. - Regenerate
composer.lockto reflect the updated dependency set.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/QueueContainer.php | Adds strict typing to PSR container methods (get/has). |
src/Logger.php | Updates logger method signatures for PSR-3 v3 compatibility. |
composer.json | Raises PHP minimum and upgrades PSR package constraints. |
composer.lock | Locks updated dependency graph for the new constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+101
to
+104
| * @param string $message The log message. | ||
| * @param array $context The error context data. | ||
| */ | ||
| public function debug( $message, array $context = [] ) { | ||
| public function debug( \Stringable|string $message, array $context = [] ) : void { |
Comment on lines
197
to
+201
| * @param mixed $level The log level. | ||
| * @param string $message The log message. | ||
| * @param array $context The error context data. | ||
| */ | ||
| public function log( $level, $message, array $context = [] ) : void { | ||
| public function log( mixed $level, \Stringable|string $message, array $context = [] ) : void { |
| "php": "^8.0", | ||
| "psr/log": "^1.1.3", | ||
| "psr/container": "^1.1.1" | ||
| "php": "^8.3", |
Comment on lines
30
to
34
| "require": { | ||
| "php": "^8.0", | ||
| "psr/log": "^1.1.3", | ||
| "psr/container": "^1.1.1" | ||
| "php": "^8.3", | ||
| "psr/log": "^3.0", | ||
| "psr/container": "^2.0" | ||
| }, |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
Dockerfile:8
- Switching the base image to
php:8.3-clilikely breaks theapt-get install -y python-pip/pip ...steps (Debian-based PHP 8.3 images typically don’t ship apython-pippackage anymore). Update the Dockerfile to install Python 3 tooling instead (e.g.,python3-pipand usepip3) sopywatchinstallation works on this base image.
FROM php:8.3-cli
MAINTAINER devgeniem
RUN apt-get update
RUN apt-get install -y python-pip
RUN pip install -U pip
RUN pip install pywatch
| @@ -5,7 +5,7 @@ | |||
| * Description: WordPress Queue is a modular library for managing queued tasks in WordPress. | |||
| * Version: 1.0.2 | |||
| * Requires at least: 5.4 | |||
Comment on lines
9
to
12
| php: | ||
| - nightly | ||
| - 8.0 | ||
| - 7.4 | ||
| - 8.3 | ||
added 2 commits
May 27, 2026 12:22
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.