Uh oh!
There was an error while loading. Please reload this page.
feat: add status-page maintenance command family - #85
Merged
Conversation
Absorb the split incidents/maintenance API and add `status-pages maintenance` commands. `--scheduled` on incident create now errors instead of silently creating an incident. Wire new authoring fields (NP description, channel enabled, sms/phone_call, DEPENDENCY components) instead of hiding them from parity tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Locks the new command family and the incident-create migration guard. Also steers communicate skill copy away from scheduling via incidents. Co-authored-by: Cursor <cursoragent@cursor.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devhelm status-pages maintenance(create/list/get/update/delete/publish/dismiss/post-update).status-pages incidents create --schedulednow errors and points at the maintenance command instead of silently creating an incident.description, alert-channelenabled,sms/phone_callconfigs, DEPENDENCYservice) so parity tests stay honest.Test plan
npm test(1056 passing locally)npx tsc --noEmitdevhelm status-pages maintenance createagainst the test APIdevhelm status-pages incidents create --schedulederrors with the maintenance pointerMade with Cursor