Uh oh!
There was an error while loading. Please reload this page.
fix: accept nextCursor on TableValueResult list envelopes - #86
Merged
Conversation
Offset list commands were using a strict page parser that rejected the additive nextCursor field the API now always sends. Co-authored-by: Cursor <cursoragent@cursor.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitors list,incidents list, …) parse through a hand-rolledparsePageenvelope that was.strict()and omittednextCursor.TableValueResultnow always includesnextCursor, so CLI 1.6.0 publish-verify (and any customer list call) fails validation.nextCursorand passthrough unknown envelope keys (Postel's Law). Generated DTO schemas already did this.Test plan
npm run typecheckcli@next MINOR after releaseMade with Cursor