Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 464
Fix building for visionOS. #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -628,6 +628,9 @@ public enum Device { | ||||
| case "i386", "x86_64", "arm64": return simulator(mapToDevice(identifier: ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"] ?? "watchOS")) | ||||
| default: return unknown(identifier) | ||||
| } | ||||
| #elseif os(visionOS) | ||||
| // TODO: Replace with proper implementation for visionOS. | ||||
| return unknown(identifier) | ||||
| #else | ||||
| return unknown(identifier) | ||||
| #endif | ||||
| @@ -879,7 +882,7 @@ public enum Device { | ||||
| case .simulator(let model): return model.screenRatio | ||||
| case .unknown: return (width: -1, height: -1) | ||||
| } | ||||
| #elseif os(tvOS) | ||||
| #elseif os(tvOS) || os(visionOS) | ||||
| return (width: -1, height: -1) | ||||
| #else | ||||
| return (width: -1, height: -1) | ||||
| @@ -986,16 +989,12 @@ public enum Device { | ||||
| public var isZoomed: Bool? { | ||||
| guard isCurrent else { return nil } | ||||
| #if os(xrOS) | ||||
| return nil | ||||
| #else | ||||
| if Int(UIScreen.main.scale.rounded()) == 3 { | ||||
| // Plus-sized | ||||
| return UIScreen.main.nativeScale > 2.7 && UIScreen.main.nativeScale < 3 | ||||
| } else { | ||||
| return UIScreen.main.nativeScale > UIScreen.main.scale | ||||
| } | ||||
| #endif | ||||
| } | ||||
| /// All Touch ID Capable Devices | ||||
| @@ -1162,6 +1161,9 @@ public enum Device { | ||||
| return allTVs | ||||
| #elseif os(watchOS) | ||||
| return allWatches | ||||
| #elseif os(visionOS) | ||||
| // TODO: Replace with proper implementation for visionOS. | ||||
| ||||
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:1165 |
github-actionsBotFeb 6, 2024 •
edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:1407 |
github-actionsBotFeb 6, 2024 •
edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:1563 |
github-actionsBotFeb 6, 2024 •
edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:1699 |
github-actionsBotFeb 6, 2024 •
edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:2341 |
github-actionsBotFeb 6, 2024 •
edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOs should be resolved (Replace with proper implementa…).todoDevice.generated.swift:2395 |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todoDevice.generated.swift:632