Skip to content

Support for new May 2024 devices. - #412

Merged
Zandor300 merged 8 commits into
masterfrom
feature/2024-may-devices
May 22, 2024
Merged

Support for new May 2024 devices.#412
Zandor300 merged 8 commits into
masterfrom
feature/2024-may-devices

Conversation

@Zandor300

@Zandor300Zandor300 commented May 7, 2024

Copy link
Copy Markdown
Member

Add support for the new May 2024 devices:

  • iPad Air (11-inch)
  • iPad Air (13-inch)
  • iPad Pro (11-inch)
  • iPad Pro (13-inch)

Fixes#413

@Zandor300
Zandor300force-pushed the feature/2024-may-devices branch from d88ba44 to fff4b7eCompareMay 21, 2024 19:46
@Zandor300
Zandor300 marked this pull request as ready for review May 21, 2024 19:49
Comment threadTests/Tests.swift
.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Collection literals should not have trailing commas.
trailing_commaTests.swift:487

Comment threadTests/Tests.swift
.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Collection literals should not have trailing commas.
trailing_commaTests.swift:550

Comment threadTests/Tests.swift
.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Collection literals should not have trailing commas.
trailing_commaTests.swift:634

Comment threadTests/Tests.swift
.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Collection literals should not have trailing commas.
trailing_commaTests.swift:662

@github-actions

github-actionsBot commented May 21, 2024

Copy link
Copy Markdown
8 Warnings
⚠️Plist changed, don't forget to localize your plist values
⚠️Source/Device.generated.swift#L652 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:652
⚠️Source/Device.generated.swift#L1193 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1193
⚠️Source/Device.generated.swift#L1439 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1439
⚠️Source/Device.generated.swift#L1599 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1599
⚠️Source/Device.generated.swift#L1739 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1739
⚠️Source/Device.generated.swift#L2399 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2399
⚠️Source/Device.generated.swift#L2455 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2455

SwiftLint found issues

Warnings

FileLineReason
Tests.swift487Collection literals should not have trailing commas. (trailing_comma)
Tests.swift550Collection literals should not have trailing commas. (trailing_comma)
Tests.swift634Collection literals should not have trailing commas. (trailing_comma)
Tests.swift662Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift652TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1193TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1439TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1599TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1739TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2399TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2455TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

@Zandor300
Zandor300 merged commit 1d30c24 into masterMay 22, 2024
@Zandor300
Zandor300 deleted the feature/2024-may-devices branch May 22, 2024 06:54
furiosFast added a commit to furiosFast/DeviceKit that referenced this pull request May 31, 2024
* master:
Version bump. (v5.4.0)
Add unknown orientation variant (devicekit#411)
Version bump. (v5.3.1)
Fix path for PrivacyInfo.xcprivacy in test target.
Process Privacy manifest instead of copy on SPM. (devicekit#409)
Version bump. (v5.3.0)
Support for new May 2024 devices. (devicekit#412)
Fix ruby version not found. (devicekit#414)
Version bump. (v5.2.4)
Enable MERGEABLE_LIBRARY. (devicekit#407)
Update cocoapods to v1.15.2 in Gemfile.
Release 5.2.3
fix: Use cocoapod resource_bundles for PrivacyInfo (devicekit#397)
Fix building for visionOS. (devicekit#390)
Fix building SwiftUI previews on macOS. (devicekit#389)
Release 5.2.1 (devicekit#385)
Fix PrivacyInfo.xcprivacy not being detected on SPM. (devicekit#384)
Update swift-tools-version in Package.swift to 5.3 to support Resource files. (devicekit#381)
# Conflicts:
#	Source/Device.swift.gyb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for 13 inch iPad devices

1 participant

@Zandor300