Skip to content

Add support for iPad Mini (A17 Pro) - #429

Merged
Zandor300 merged 3 commits into
masterfrom
feature/ipad-mini-2024
Mar 11, 2025
Merged

Add support for iPad Mini (A17 Pro)#429
Zandor300 merged 3 commits into
masterfrom
feature/ipad-mini-2024

Conversation

@Zandor300

Copy link
Copy Markdown
Member

Fixes#426

Comment threadTests/Tests.swift
@@ -562,7 +564,7 @@ class DeviceKitTests: XCTestCase {
.iPadPro13M4,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️Collection literals should not have trailing commas.
trailing_commaTests.swift:564

@github-actions

Copy link
Copy Markdown
13 Warnings
⚠️Plist changed, don't forget to localize your plist values
⚠️Source/Device.generated.swift#L687 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:687
⚠️Source/Device.generated.swift#L1242 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1242
⚠️Source/Device.generated.swift#L1495 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1495
⚠️Source/Device.generated.swift#L1662 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1662
⚠️Source/Device.generated.swift#L1809 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1809
⚠️Source/Device.generated.swift#L2489 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2489
⚠️Source/Device.generated.swift#L2548 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2548
⚠️Tests/Tests.swift#L461 - Collection literals should not have trailing commas.
trailing_commaTests.swift:461
⚠️Tests/Tests.swift#L492 - Collection literals should not have trailing commas.
trailing_commaTests.swift:492
⚠️Tests/Tests.swift#L523 - Collection literals should not have trailing commas.
trailing_commaTests.swift:523
⚠️Tests/Tests.swift#L650 - Collection literals should not have trailing commas.
trailing_commaTests.swift:650
⚠️Tests/Tests.swift#L683 - Collection literals should not have trailing commas.
trailing_commaTests.swift:683

SwiftLint found issues

Warnings

FileLineReason
Tests.swift461Collection literals should not have trailing commas. (trailing_comma)
Tests.swift492Collection literals should not have trailing commas. (trailing_comma)
Tests.swift523Collection literals should not have trailing commas. (trailing_comma)
Tests.swift564Collection literals should not have trailing commas. (trailing_comma)
Tests.swift650Collection literals should not have trailing commas. (trailing_comma)
Tests.swift683Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift687TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1242TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1495TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1662TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1809TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2489TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2548TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

@Zandor300
Zandor300 merged commit 866ddd8 into masterMar 11, 2025
@Zandor300
Zandor300 deleted the feature/ipad-mini-2024 branch March 11, 2025 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPad mini (A17 Pro) missing

1 participant

@Zandor300