Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models by Copilot · Pull Request #474 · devicekit/DeviceKit

Copilot · 2025-11-17T21:11:12Z

Fix incorrect Apple Pencil compatibility for recent iPad models

Based on Apple's official documentation at https://support.apple.com/en-au/HT211029:

Changes Summary:

✅ iPad (10th gen) & iPad (A16)

Before: Apple Pencil (USB-C) only
After: Apple Pencil (1st gen) + Apple Pencil (USB-C)

✅ iPad Air 11" & 13" (M2)

Before: Apple Pencil (2nd gen) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

✅ iPad Air 11" & 13" (M3)

Before: Apple Pencil (2nd gen) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

✅ iPad Pro 11" & 13" (M4)

Before: Apple Pencil (2nd gen) + Apple Pencil (USB-C) + Apple Pencil Pro
After: Apple Pencil (USB-C) + Apple Pencil Pro

Technical Changes:

Files Changed:

Source/Device.swift.gyb - Updated device definitions and added template case for value 13
Source/Device.generated.swift - Regenerated from template without sourceLocation lines
Tests/Tests.swift - Added tests validating all changes
CHANGELOG.md - Added bug fix entry

Note: This project requires macOS with Xcode to build and test. The CI pipeline will validate these changes on macOS.

Original prompt

This section details on the original issue you should resolve
<issue_title>Incorrect Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models</issue_title>
<issue_description>Device.applePencilSupport currently lists incorrect Apple Pencil compatibility for several recent iPad models.
Apple’s official documentation: https://support.apple.com/en-au/HT211029
M4 iPad Pro (11/13") – Does not support Apple Pencil (2nd gen). Supports Pencil Pro and Pencil (USB-C).
iPad Air (M2/M3, 11" & 13") – Supports Pencil Pro and Pencil (USB-C), not 2nd gen.
iPad (10th gen) & iPad (A16) – Supports Pencil (USB-C) and Pencil (1st gen).
Proposed fix:
case .iPadPro11M4,.iPadPro13M4:return[.firstGenerationUsbC,.pro]
case .iPadAir11M2,.iPadAir13M2,.iPadAir11M3,.iPadAir13M3:return[.firstGenerationUsbC,.pro]
case .iPad10,.iPadA16:return[.firstGenerationUsbC,.firstGeneration]</issue_description>
## Comments on the Issue (you are @copilot in this section)<comments></comments>

FixesIncorrect Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models #460

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

github-actions · 2025-11-17T21:19:49Z

	8 Warnings
⚠️	Plist changed, don't forget to localize your plist values
⚠️	Source/Device.generated.swift#L777 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:777`
⚠️	Source/Device.generated.swift#L1368 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:1368`
⚠️	Source/Device.generated.swift#L1639 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:1639`
⚠️	Source/Device.generated.swift#L1824 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:1824`
⚠️	Source/Device.generated.swift#L1989 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:1989`
⚠️	Source/Device.generated.swift#L2710 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:2710`
⚠️	Source/Device.generated.swift#L2772 - TODOs should be resolved (Replace with proper implementa…). `todoDevice.generated.swift:2772`

SwiftLint found issues

Warnings

File	Line	Reason
Device.generated.swift	777	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1368	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1639	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1824	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	1989	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	2710	TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift	2772	TODOs should be resolved (Replace with proper implementa...). (todo)

Errors

File	Line	Reason
Device.generated.swift	626	Function should have complexity 10 or less: currently complexity equals 140 (cyclomatic_complexity)

Generated by 🚫 Danger

Zandor300 · 2025-11-17T21:22:55Z

@copilot remove sourceLocation lines from generated Swift file.

Copilot · 2025-11-17T21:30:40Z

@copilot remove sourceLocation lines from generated Swift file.

Done! Regenerated the file using gyb.py --line-directive '' to suppress the sourceLocation debug markers. All 1235 lines removed while preserving the Apple Pencil compatibility fixes. (774cb6c)

Copilot

Pull request overview

This PR fixes incorrect Apple Pencil compatibility information for recent iPad models by updating the applePencilSupport property to match Apple's official documentation. The changes correct compatibility for M4 iPad Pro, M2/M3 iPad Air, and 10th generation iPad models.

Key changes:

Added template support for the value 13 combination (1st gen + USB-C Pencil) in the code generation template
Updated 8 iPad models with corrected Apple Pencil support values
Added comprehensive test coverage for all affected devices

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
Source/Device.swift.gyb	Updated applePencilSupport values for 8 iPad models (iPad 10th gen, iPad A16, 4 iPad Air models, 2 iPad Pro M4 models) and added template case for value 13
Source/Device.generated.swift	Regenerated Swift code from template with corrected Apple Pencil support arrays for all affected devices
Tests/Tests.swift	Added testApplePencilSupport() function with 50 lines of assertions validating correct Pencil support for all 8 affected iPad models

Zandor300 · 2025-12-02T09:52:22Z

@copilot Please add a changelog entry and fix linting errors from swiftlint on the lines you changed. Don't apply linting fixes to lines that you haven't touched previously inside this PR.

Copilot · 2025-12-02T09:56:23Z

@copilot Please add a changelog entry and fix linting errors from swiftlint on the lines you changed. Don't apply linting fixes to lines that you haven't touched previously inside this PR.

Added changelog entry and fixed trailing whitespace on blank lines in testApplePencilSupport(). (2011d0e)

Zandor300 · 2025-12-03T19:57:42Z

@copilot You need to rebase on master.

Copilot · 2025-12-03T19:58:35Z

@copilot You need to rebase on master.

I'm unable to perform a rebase as it requires force push, which I don't have access to. Could you please rebase this branch on master? Once done, I can continue with any additional changes needed.

Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

The firstGenerationUsbC raw value (0x03) overlapped with firstGeneration (0x01) and secondGeneration (0x02), causing contains() checks to return incorrect results. Changed to proper power-of-2 values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-03-02T16:47:59Z

 ///
 /// - returns: An initialized `Device`.
- public static func mapToDevice(identifier: String) -> Device { // swiftlint:disable:this cyclomatic_complexity function_body_length
+ public static func mapToDevice(identifier: String) -> Device {


⚠️ Function should have complexity 10 or less: currently complexity equals 140
cyclomatic_complexityDevice.generated.swift:626

…els (devicekit#474) * Initial plan * Fix Apple Pencil compatibility for iPad models * Add tests for Apple Pencil compatibility * Add changelog entry and fix trailing whitespace in tests * Fix linting issues. * Fix changelog entry. * Fix additional linting issues. * Fix ApplePencilSupport OptionSet raw values to use non-overlapping bits The firstGenerationUsbC raw value (0x03) overlapped with firstGeneration (0x01) and secondGeneration (0x02), causing contains() checks to return incorrect results. Changed to proper power-of-2 values.

CopilotAI assigned Copilot and Zandor300 Nov 17, 2025

Copilotstarted work on behalf of Zandor300 November 17, 2025 21:11 View session

CopilotAI changed the title ~~[WIP] Fix incorrect Apple Pencil compatibility for iPad models~~Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air modelsNov 17, 2025

CopilotAI requested a review from Zandor300 November 17, 2025 21:27

Copilotfinished work on behalf of Zandor300 November 17, 2025 21:27

Copilotstarted work on behalf of Zandor300 November 17, 2025 21:28 View session

Copilotfinished work on behalf of Zandor300 November 17, 2025 21:32

Zandor300 requested review from Copilot and removed request for Zandor300 December 2, 2025 06:18

Copilotstarted reviewing on behalf of Zandor300 December 2, 2025 06:18 View session

Copilotfinished reviewing on behalf of Zandor300 December 2, 2025 06:19

CopilotAI reviewed Dec 2, 2025
View reviewed changes

Copilotstarted work on behalf of Zandor300 December 2, 2025 09:52 View session

Copilotfinished work on behalf of Zandor300 December 2, 2025 09:57

CopilotAI requested a review from Zandor300 December 2, 2025 09:57

Zandor300 force-pushed the copilot/fix-apple-pencil-compatibility branch from 9b4a20f to ff78b6eCompare December 3, 2025 19:31

Copilotstarted work on behalf of Zandor300 December 3, 2025 19:58 View session

Copilotfinished work on behalf of Zandor300 December 3, 2025 19:59

Zandor300 force-pushed the copilot/fix-apple-pencil-compatibility branch from 4ed1389 to a50c628Compare December 3, 2025 20:02

Zandor300 marked this pull request as ready for review March 2, 2026 15:27

CopilotAIand others added 2 commits March 2, 2026 17:39

Initial plan
cef261c

Fix Apple Pencil compatibility for iPad models
00b7c0f
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

CopilotAIand others added 6 commits March 2, 2026 17:44

Add tests for Apple Pencil compatibility
09e445b
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Add changelog entry and fix trailing whitespace in tests
b201443
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>

Fix linting issues.
b14724e

Fix changelog entry.
2700344

Fix additional linting issues.
6920593

Zandor300 force-pushed the copilot/fix-apple-pencil-compatibility branch from 46fce1b to a43c030Compare March 2, 2026 16:45

github-actionsBot reviewed Mar 2, 2026
View reviewed changes

Zandor300 merged commit 5314fea into masterMar 2, 2026
10 checks passed

Zandor300 deleted the copilot/fix-apple-pencil-compatibility branch March 2, 2026 16:55

Navigation Menu

Uh oh!

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models - #474

Fix Apple Pencil compatibility for M4 iPad Pro and M2/M3 iPad Air models#474
Zandor300 merged 8 commits into
masterfrom
copilot/fix-apple-pencil-compatibility

CopilotAI commented Nov 17, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Nov 17, 2025•
edited
Loading

Uh oh!

Zandor300 commented Nov 17, 2025

Uh oh!

CopilotAI commented Nov 17, 2025

Uh oh!

CopilotAI left a comment

Uh oh!

Zandor300 commented Dec 2, 2025

Uh oh!

CopilotAI commented Dec 2, 2025

Uh oh!

Zandor300 commented Dec 3, 2025

Uh oh!

CopilotAI commented Dec 3, 2025

Uh oh!

github-actionsBotMar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

CopilotAI commented Nov 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Nov 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SwiftLint found issues

Warnings

Errors

Uh oh!

Zandor300 commented Nov 17, 2025

Uh oh!

CopilotAI commented Nov 17, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Zandor300 commented Dec 2, 2025

Uh oh!

CopilotAI commented Dec 2, 2025

Uh oh!

Zandor300 commented Dec 3, 2025

Uh oh!

CopilotAI commented Dec 3, 2025

Uh oh!

github-actionsBotMar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Nov 17, 2025•
edited
Loading

github-actionsBot commented Nov 17, 2025•
edited
Loading