Skip to content

Rename iPad Mini to iPad mini for Apple naming consistency - #478

Merged
Zandor300 merged 3 commits into
masterfrom
copilot/fix-ipad-mini-naming
Mar 2, 2026
Merged

Rename iPad Mini to iPad mini for Apple naming consistency#478
Zandor300 merged 3 commits into
masterfrom
copilot/fix-ipad-mini-naming

Conversation

CopilotAI commented Dec 3, 2025

Copy link
Copy Markdown
Contributor
  • Update Source/Device.swift.gyb to change "iPad Mini" to "iPad mini" in strings and comments (lines 120-126)
  • Regenerate Source/Device.generated.swift using the gyb tool
  • Update Tests/Tests.swift to match new "iPad mini" string values (lines 358-362)
  • Update CHANGELOG.md to reflect "iPad mini" naming (4 occurrences)
  • Add changelog entry under Unreleased for iPad mini naming fix
  • Run code review
  • Run CodeQL security scan
Original prompt

This section details on the original issue you should resolve

<issue_title>iPad Mini vs. iPad mini</issue_title>
<issue_description>Thank you for creating this amazing library.

If anyone is excited by nitpicky details, for consistency with Apple's naming, the capitalization of "iPad Mini" should be "iPad mini".

See Device.swift.gyb, lines 120 through 126

Device("iPadMini", "Device is an [iPad Mini](https://support.apple.com/kb/SP661)", "https://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/SP661/sp661_ipad_mini_color.jpg", ["iPad2,5", "iPad2,6", "iPad2,7"], 7.9, (3, 4), "iPad Mini", "iPad Mini", 163, False, True, False, False, False, False, False, False, False, False, 0, False, 1, False, "a5", False, False),

Please let me know if you'd like me to create a PR for this issue.</issue_description>

<agent_instructions>Rename all iPad Mini to iPad mini with lowercase m. Only inside strings and comments. Keep the enum still with capital M according to lowerCamelCasing.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

CopilotAI changed the title [WIP] Fix capitalization of iPad Mini to iPad miniRename iPad Mini to iPad mini for Apple naming consistencyDec 3, 2025
CopilotAI requested a review from Zandor300December 3, 2025 19:50
@Zandor300

Copy link
Copy Markdown
Member

@copilot Please add a new changelog entry under unreleased about fixing naming of iPad mini.

@github-actions

github-actionsBot commented Dec 3, 2025

Copy link
Copy Markdown
9 Warnings
⚠️Plist changed, don't forget to localize your plist values
⚠️Source/Device.generated.swift#L626 - Function should have complexity 10 or less: currently complexity equals 140
cyclomatic_complexityDevice.generated.swift:626
⚠️Source/Device.generated.swift#L777 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:777
⚠️Source/Device.generated.swift#L1368 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1368
⚠️Source/Device.generated.swift#L1639 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1639
⚠️Source/Device.generated.swift#L1824 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1824
⚠️Source/Device.generated.swift#L1989 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:1989
⚠️Source/Device.generated.swift#L2710 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2710
⚠️Source/Device.generated.swift#L2772 - TODOs should be resolved (Replace with proper implementa…).
todoDevice.generated.swift:2772

SwiftLint found issues

Warnings

FileLineReason
Device.generated.swift777TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1368TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1639TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1824TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift1989TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2710TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift2772TODOs should be resolved (Replace with proper implementa...). (todo)

Errors

FileLineReason
Device.generated.swift626Function should have complexity 10 or less: currently complexity equals 140 (cyclomatic_complexity)

Generated by 🚫 Danger

CopilotAI commented Dec 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@copilot Please add a new changelog entry under unreleased about fixing naming of iPad mini.

Added the changelog entry under the Unreleased section in commit 304adfa.

@Zandor300
Zandor300 marked this pull request as ready for review December 3, 2025 19:56
@Zandor300
Zandor300force-pushed the copilot/fix-ipad-mini-naming branch from 304adfa to 1e1ab7eCompareMarch 2, 2026 16:50
CopilotAIand others added 3 commits March 2, 2026 17:55
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
Co-authored-by: Zandor300 <6069593+Zandor300@users.noreply.github.com>
@Zandor300
Zandor300force-pushed the copilot/fix-ipad-mini-naming branch from 1e1ab7e to 1ff909fCompareMarch 2, 2026 16:57
@Zandor300
Zandor300 merged commit ee6239c into masterMar 2, 2026
10 checks passed
@Zandor300
Zandor300 deleted the copilot/fix-ipad-mini-naming branch March 2, 2026 19:12
dmaglia pushed a commit to dmaglia/DeviceKit that referenced this pull request Mar 23, 2026
…#478)
* Initial plan
* Rename iPad Mini to iPad mini in strings and comments
* Add changelog entry for iPad mini naming fix
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPad Mini vs. iPad mini

2 participants

@Zandor300