Skip to content

Fix multiline values being truncated - #392

Merged
kzu merged 1 commit into
mainfrom
dev/multiline
Sep 17, 2024
Merged

Fix multiline values being truncated#392
kzu merged 1 commit into
mainfrom
dev/multiline

Conversation

@kzu

@kzukzu commented Sep 17, 2024

Copy link
Copy Markdown
Member

Just like we do for semicolon-separated values (encoding them prior to persistence to editorconfig/analyzer config), we now encode newlines as \n and decode them prior to emitting source code.

This makes previously failing scenarios work (i.e. project properties) as well as fixing previously working ones in AssemblyInfo generator (i.e. Description property).

Fixes#390

@kzu
Fix multiline values being truncated
c051752
Just like we do for semicolon-separated values (encoding them prior to persistence to editorconfig/analyzer config), we now encode newlines as `\n` and decode them prior to emitting source code.
This makes previously failing scenarios work (i.e. project properties) as well as fixing previously working ones in AssemblyInfo generator (i.e. Description property).
Fixes#390
@kzukzu added the enhancement New feature or request label Sep 17, 2024
@kzu
kzu enabled auto-merge (rebase) September 17, 2024 01:08
@devlooped-bot

devlooped-bot commented Sep 17, 2024

Copy link
Copy Markdown
Member

24 passed24 passed

🧪 Details on macOS Unix 14.6.1

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource

from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜

@devlooped-bot

devlooped-bot commented Sep 17, 2024

Copy link
Copy Markdown
Member

24 passed24 passed

🧪 Details on Ubuntu 22.04.4 LTS

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource

from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜

@devlooped-bot

devlooped-bot commented Sep 17, 2024

Copy link
Copy Markdown
Member

24 passed24 passed

🧪 Details on Microsoft Windows 10.0.20348

✅ ThisAssemblyTests.ScribanTests.CanRenderModel
✅ ThisAssemblyTests.Tests.CanReadResourceFile
✅ ThisAssemblyTests.Tests.CanUseByteResource
✅ ThisAssemblyTests.Tests.CanUseConstants
✅ ThisAssemblyTests.Tests.CanUseFileConstantInvalidIdentifier
✅ ThisAssemblyTests.Tests.CanUseFileConstantLinkedFile
✅ ThisAssemblyTests.Tests.CanUseFileConstants
✅ ThisAssemblyTests.Tests.CanUseFileInvalidCharacters
✅ ThisAssemblyTests.Tests.CanUseGitBranchConstants
✅ ThisAssemblyTests.Tests.CanUseGitConstants
✅ ThisAssemblyTests.Tests.CanUseHierarchicalMetadata
✅ ThisAssemblyTests.Tests.CanUseInfo
✅ ThisAssemblyTests.Tests.CanUseInfoDescription
✅ ThisAssemblyTests.Tests.CanUseMetadata
✅ ThisAssemblyTests.Tests.CanUseMultilineProjectProperty
✅ ThisAssemblyTests.Tests.CanUseProjectProperty
✅ ThisAssemblyTests.Tests.CanUseSameNameDifferentExtensions
✅ ThisAssemblyTests.Tests.CanUseSemicolonsInConstant
✅ ThisAssemblyTests.Tests.CanUseStringResource
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsIndexedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedArguments
✅ ThisAssemblyTests.Tests.CanUseStringsNamedFormattedArguments
✅ ThisAssemblyTests.Tests.CanUseTextResource

from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜

@kzu
kzu merged commit 437436b into mainSep 17, 2024
@kzu
kzu deleted the dev/multiline branch September 17, 2024 01:18
@devloopeddevlooped locked and limited conversation to collaborators Oct 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiline item values get truncated

2 participants

@kzu@devlooped-bot