Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CreateUtcRangediretamente com umstringnão anulável.Description
TimeZonePolicyemsrc/Odca.Application/Tenancy/TimeZonePolicy.csque resolve o fuso com precedência pelo valor da organização e fallback explícito da aplicação, distinguindo os casosMissing,Empty,InvalideUnavailable.ContractImportsControllerpara resolver oTimeZoneInfoantes de criar o intervalo UTC, tratar exceções de configuração com respostas controladas ao cliente e alterar a assinatura deCreateUtcRangepara receberTimeZoneInfo; arquivos principais modificados:src/Odca.Api/Controllers/ContractImportsController.csesrc/Odca.Api/appsettings.json.DateOnlyem instantes UTC ao rejeitar inícios inexistentes (IsInvalidTime), escolher explicitamente o primeiro instante em tempos ambíguos (IsAmbiguousTime) e validar intervalos invertidos e limites (ArgumentExceptionparafrom > to).HostOptions.ShutdownTimeout(2 minutos) emsrc/Odca.Worker/Program.cs, tornando o helperRundoDocumentWorkercancelável e assegurando que processos-filho sejam encerrados e aguardados quando o host cancela, emsrc/Odca.Worker/DocumentWorker.cs.scripts/stop-local.ps1para identificar e encerrar processos pertencentes ao checkout e ajuste emscripts/run-local.ps1para iniciar projetos com caminhos absolutos; também atualizaREADME.mdcom procedimento Windows para diagnosticar bloqueios.DocumentWorker.Runinternale expõe o Worker a testes comInternalsVisibleTo, adiciona testes unitários/integrados novos para política de fuso, intervalos e cancelamento (tests/Odca.Domain.Tests/TimeZonePolicyTests.cs,tests/Odca.IntegrationTests/ContractImportDateRangeTests.cs,tests/Odca.IntegrationTests/DocumentWorkerCancellationTests.cs) e registra a referência ao projeto Worker emtests/Odca.IntegrationTests/Odca.IntegrationTests.csproj.Testing
git diff --checkpassou e os JSON modificados foram validados compython3carregandosrc/Odca.Api/appsettings.jsonesrc/Odca.Worker/Properties/launchSettings.jsonsem erros.taskkill,dotnet.exe,HintPathetc.) passou sem encontrar soluções proibidas.dotnet restore,dotnet buildedotnet testnão foi possível neste runner porque o bináriodotnetnão está instalado, portanto os testes não foram executados aqui.dotnet restore Odca.sln --locked-mode,dotnet build Odca.sln --configuration Release --no-restore,dotnet test tests/Odca.Domain.Tests --no-build,dotnet test tests/Odca.IntegrationTests --no-build, e para diagnosticar/encerra processos Windows. ools un-local.ps1/. ools un-local.ps1 -Force(conforme documentado noREADME.md).Codex Task