Skip to content

Allow -before-NUMBER files in sponsors directory guard - #16060

Merged
nimbinatus merged 1 commit into
mainfrom
matty/sponsor-guard-before-exception
Aug 7, 2026
Merged

Allow -before-NUMBER files in sponsors directory guard#16060
nimbinatus merged 1 commit into
mainfrom
matty/sponsor-guard-before-exception

Conversation

@mattstratton

Copy link
Copy Markdown
Member

Summary

  • The sponsor-assets guard workflow blocks any PR touching static/img/sponsors/**.
  • Adds an exception so files whose name contains -before-<number> (e.g. logo-before-2026.png) are allowed through without tripping the block or comment.
  • If a change mixes exempt and non-exempt files, only the non-exempt files are listed in the block comment and the check still fails.

Test plan

  • Open a test PR that only adds/modifies a *-before-2026.* file under static/img/sponsors/ and confirm the guard check passes with no comment.
  • Open a test PR with a non-exempt file under static/img/sponsors/ and confirm the guard still comments and fails as before.

🤖 Generated with Claude Code

Exempt files matching the "-before-<number>" naming pattern (e.g.
logo-before-2026.png) from the static/img/sponsors/ change block.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mattstratton
mattstratton requested a review from a team as a code ownerAugust 7, 2026 12:33
@netlify

netlifyBot commented Aug 7, 2026

Copy link
Copy Markdown

Deploy Preview for devopsdays-web ready!

NameLink
🔨 Latest commit9d92ed2
🔍 Latest deploy loghttps://app.netlify.com/projects/devopsdays-web/deploys/6a75d0a8d936ea00076a6e35
😎 Deploy Previewhttps://deploy-preview-16060--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@mattstratton

Copy link
Copy Markdown
MemberAuthor

Note that the proposed test plan in the PR description wouldn't actually work because you have to commit github actions to main before they run

@nimbinatusnimbinatus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mattstratton !!

@nimbinatus
nimbinatus merged commit 8e79e1c into mainAug 7, 2026
9 checks passed
@nimbinatus
nimbinatus deleted the matty/sponsor-guard-before-exception branch August 7, 2026 13:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mattstratton@phrawzty@nimbinatus