feature: adding api_base option - #96

Merged
devrnt merged 21 commits into
devrnt:masterfrom
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged

feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom
doankhoi:feature/adding-api-base-property

Conversation

@doankhoi

@doankhoidoankhoi commented Sep 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@devrnt

devrnt commented Sep 28, 2020

Copy link
Copy Markdown
Owner

Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?

@devrntdevrnt added the discussion Get feedback for a possible improvement label Sep 28, 2020
@doankhoi

doankhoi commented Sep 28, 2020

Copy link
Copy Markdown
ContributorAuthor

This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM

@devrnt

devrnt commented Sep 28, 2020

Copy link
Copy Markdown
Owner

I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?

@devrnt

devrnt commented Oct 5, 2020

Copy link
Copy Markdown
Owner

@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.

devrntand others added 18 commits October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt

devrnt commented Oct 15, 2020

Copy link
Copy Markdown
Owner

Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files

@devrnt
devrnt merged commit c8492c8 into devrnt:masterOct 15, 2020
@musiquarc

musiquarc commented Jan 10, 2023

Copy link
Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.

The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :

Regional Location | API Base to Set
US | https://api-iam.intercom.io
EU | https://api-iam.eu.intercom.io
Australia | https://api-iam.au.intercom.io

Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :
"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"

I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.

To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.

Thanks !

@devrnt

devrnt commented Jan 10, 2023•
edited
Loading

Copy link
Copy Markdown
Owner

Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required

@pradeepgill007

pradeepgill007 commented Mar 24, 2023

Copy link
Copy Markdown

It does not work for me as well.
I tried to implement it for EU | https://api-iam.eu.intercom.io/

Removing the react-use-intercom package from my project.

@timonbimontimonbimon mentioned this pull request Jun 28, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

discussionGet feedback for a possible improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feature: adding api_base option - #96
Merged
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Oct 15, 2020
Merged
feature: adding api_base option#96
devrnt merged 21 commits into
devrnt:masterfrom 
doankhoi:feature/adding-api-base-property
Conversation
@doankhoi
@doankhoidoankhoi
commented
Sep 24, 2020

Copy link


Copy Markdown

Contributor
 No description provided. 
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
Thanks for your PR. Can I ask why this dynamic api_base is needed? I did a search and did not find anything about this base url in the Intercom docs. Could you provide a link to your source?
@devrntdevrnt
added
the 
discussion
Get feedback for a possible improvement
label
Sep 28, 2020
@doankhoi
doankhoi
commented
Sep 28, 2020

Copy link


Copy Markdown

ContributorAuthor
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added api_base attribute to their config
Screen Shot 2020-09-28 at 11 49 22 PM
@devrnt
devrnt
commented
Sep 28, 2020

Copy link


Copy Markdown

Owner
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects?
@devrnt
devrnt
commented
Oct 5, 2020

Copy link


Copy Markdown

Owner
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR.
devrntand others
added 18 commits
October 15, 2020 20:17
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
95f0b72
…i/react-use-intercom into pr/doankhoi/96
@devrnt
chore: update docs of api base prop in provider
f917ecb
@devrnt
test: add cypress test for api base
2bbb513
@devrnt
test: add integration test for api base
7ac540b
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 10.4.9 to 11.0.0
13e6673
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.0 to 11.0.2
cdaae84
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump husky from 4.2.5 to 4.3.0
5bb6da8
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](typicode/husky@v4.2.5...v4.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump @testing-library/react from 11.0.2 to 11.0.4
53608d6
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4.
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump cypress from 5.1.0 to 5.2.0
770a9c7
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v5.1.0...v5.2.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview@devrnt
chore(deps-dev): bump typescript from 4.0.2 to 4.0.3
3bd8bfd
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.2...v4.0.3)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@doankhoi@devrnt
feat: add api base prop in provider
fbb79f8
@dependabot-preview@devrnt
chore(deps-dev): bump tsdx from 0.13.3 to 0.14.0
b67e4a8
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0.
- [Release notes](https://github.com/formium/tsdx/releases)
- [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@devrnt
test: update jest config
4b7b921
@doankhoi@devrnt
chore: make api base an optional prop
e0a4487
@devrnt
chore: update docs of api base prop in provider
ba5646d
@devrnt
test: add cypress test for api base
6af281e
@devrnt
test: add integration test for api base
c3ad2b2
@devrnt
Merge branch 'feature/adding-api-base-property' of github.com:doankho…
ae0704b
…i/react-use-intercom into pr/doankhoi/96
@devrnt
devrnt
commented
Oct 15, 2020

Copy link


Copy Markdown

Owner
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files
@devrnt
devrnt
merged commit c8492c8
into
devrnt:masterOct 15, 2020
@musiquarc
musiquarc
commented
Jan 10, 2023

Copy link


Copy Markdown

Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom.
The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for api_base :
Regional Location | API Base to Set

US | https://api-iam.intercom.io

EU | https://api-iam.eu.intercom.io

Australia | https://api-iam.au.intercom.io
Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props apiBase :

"apiBase | If you need to route your Messenger requests through a different endpoint than the default. Generally speaking, this is not needed. Format: https://${INTERCOM_APP_ID}.intercom-messenger.com"
I have tried both https://api-iam.eu.intercom.io and https://${INTERCOM_APP_ID}.intercom-messenger.com apiBase formats, without success.
To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation.
Thanks !
@devrnt
devrnt
commented
Jan 10, 2023•

edited

Loading

Copy link


Copy Markdown

Owner
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the apiBase if required
@pradeepgill007
pradeepgill007
commented
Mar 24, 2023

Copy link


Copy Markdown

It does not work for me as well.

I tried to implement it for EU | https://api-iam.eu.intercom.io/
Removing the react-use-intercom package from my project.
@timonbimontimonbimon
mentioned this pull request
Jun 28, 2023

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

discussionGet feedback for a possible improvement

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@doankhoi@devrnt@musiquarc@pradeepgill007