fix(release): restore macOS signing on macOS 26 runners - #1208
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the ChangesElectron Builder Update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the desktop packaging dependency to restore macOS release signing behavior. The dependency declaration and lockfile are aligned, with no concrete current-head merge risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.8)desktop/package.jsonBiome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Tick the box to add this pull request to the merge queue (same as
|
Problem
macOS release packaging jobs fail during
electron-builderkeychain setup with:Root Cause
electron-builder26.15.3 incorrectly passed the.p12import password (CSC_KEY_PASSWORD) tosecurity set-key-partition-list -k, which requires the temporary keychain password. The defect was exposed when GitHub Actions updatedmacos-latestto macOS 26 runner images, which strictly enforce validation of the keychain password.Fix
Upgrade
electron-builderto26.16.1, which contains the upstream fix (passingkeychainPasswordtoset-key-partition-list -k).Verification
npx electron-builder --version->26.16.1set-key-partition-listimplementation inapp-builder-libuseskeychainPasswordtask desktop:checkpassed with 0 errors / 0 warningsxvfb-run task desktop:testpassed (38 test files, 328 tests)npm run electron:buildsucceededReferences
Summary by CodeRabbit