Skip to content

fix(release): restore macOS signing on macOS 26 runners - #1208

Merged
skevetter merged 1 commit into
mainfrom
fix/restore-macos-release-signing
Sep 9, 2026
Merged

fix(release): restore macOS signing on macOS 26 runners#1208
skevetter merged 1 commit into
mainfrom
fix/restore-macos-release-signing

Conversation

@skevetter

@skevetter skevetter commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Problem

macOS release packaging jobs fail during electron-builder keychain setup with:

security: SecKeychainUnlock: The user name or passphrase you entered is not correct.

Root Cause

electron-builder 26.15.3 incorrectly passed the .p12 import password (CSC_KEY_PASSWORD) to security set-key-partition-list -k, which requires the temporary keychain password. The defect was exposed when GitHub Actions updated macos-latest to macOS 26 runner images, which strictly enforce validation of the keychain password.

Fix

Upgrade electron-builder to 26.16.1, which contains the upstream fix (passing keychainPassword to set-key-partition-list -k).

Verification

  • npx electron-builder --version -> 26.16.1
  • Verified set-key-partition-list implementation in app-builder-lib uses keychainPassword
  • task desktop:check passed with 0 errors / 0 warnings
  • xvfb-run task desktop:test passed (38 test files, 328 tests)
  • npm run electron:build succeeded
  • CodeRabbit CLI local review passed with 0 findings
  • Pre-commit hooks passed
  • Commit is signed

References

Summary by CodeRabbit

  • Chores
    • Updated the desktop application packaging tooling to a newer version.

@netlify

netlify Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 6ef5d9c
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6aa0bf2f5646e300083e7444

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 25f3f700-75c6-4caf-b435-941e3ebf6db4

📥 Commits

Reviewing files that changed from the base of the PR and between e1177bb and 6ef5d9c.

⛔ Files ignored due to path filters (1)
  • desktop/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • desktop/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the electron-builder development dependency in desktop/package.json from 26.15.3 to 26.16.1.

Changes

Electron Builder Update

Layer / File(s) Summary
Update Electron Builder version
desktop/package.json
The electron-builder development dependency changes from 26.15.3 to 26.16.1.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6ef5d

This updates the desktop packaging dependency to restore macOS release signing behavior. The dependency declaration and lockfile are aligned, with no concrete current-head merge risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the electron-builder-related release fix that restores macOS signing on macOS 26 runners. It matches the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/restore-macos-release-signing

Warning

Some tools did not complete. Review the errors below.

🔧 Biome (2.5.8)
desktop/package.json

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 6ef5d9c
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6aa0bf2ff36c4b00081ddf0b

@github-actions github-actions Bot added the size/m label Sep 9, 2026
@skevetter
skevetter marked this pull request as ready for review September 9, 2026 05:12
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@skevetter
skevetter merged commit b291bd1 into main Sep 9, 2026
31 checks passed
@skevetter
skevetter deleted the fix/restore-macos-release-signing branch September 9, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant