Skip to content

fix(lifecycle): surface deferred hook errors instead of swallowing them#189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
May 4, 2026
Merged

fix(lifecycle): surface deferred hook errors instead of swallowing them #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/agent/container/deferred_hooks.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ package container
import (
"context"
"encoding/json"
"fmt"

"github.com/devsy-org/devsy/cmd/flags"
"github.com/devsy-org/devsy/pkg/compress"
Expand DownExpand Up@@ -70,12 +71,11 @@ func (cmd *DeferredHooksCmd) Run(ctx context.Context) error {
RemoteUser: config.GetRemoteUser(setupInfo),
}, cmd.SecretsEnv)
if err != nil {
log.Errorf("deferred hooks setup failed: %v", err)
return nil
return fmt.Errorf("deferred hooks setup: %w", err)
}

if err := deferred.Run(); err != nil {
log.Errorf("deferred lifecycle hooks failed: %v", err)
return fmt.Errorf("deferred lifecycle hooks: %w", err)
}

return nil
Expand Down
Loading