feat(cli): rewrite set-up command to full devcontainer spec compliance

[skevetter]

Summary

Rewrites the set-up command from a minimal 2-hook stub to full devcontainer spec compliance for BYOC (Bring Your Own Container) workflows:

• Runs all 5 lifecycle hooks in spec order: onCreateCommand → updateContentCommand → postCreateCommand → postStartCommand → postAttachCommand
• Validates container is running before execution via docker inspect
• Uses merged config pipeline (ParseDevContainerJSON + MergeConfiguration) matching the run-user-commands pattern
• Supports both remoteEnv and containerEnv via docker exec -e flags
• Adds --docker-path flag for custom docker/podman executable
• Adds --result-format support for JSON envelope output (success/error)
• Installs devcontainer features into running containers (resolve order → stage files → docker cp → docker exec install scripts)
• Exports GetFeatureEnvVariables and GetFeatureInstallWrapperScript from the feature package for reuse

E2E tests extended with onCreateCommand, updateContentCommand, postAttachCommand, remoteEnv, lifecycle ordering, and local feature installation coverage.

Summary by CodeRabbit

• New Features

  • Added optional Docker path configuration to the setup command
  • Introduced devcontainer feature installation with environment variable propagation and custom install scripts
  • Expanded lifecycle hook execution support

• Tests

  • Enhanced end-to-end test coverage for lifecycle command execution, feature installation, and hook ordering
  • Added validation tests for Docker path configuration and setup functionality

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	cbb0ce4
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/69fb9abc3b02010008d7f3c4

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8556560-84cc-45d3-8938-7f1fca021bfe

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd07e5 and cbb0ce4.

📒 Files selected for processing (8)

• cmd/exec_test.go
• cmd/runusercommands_test.go
• cmd/setup.go
• cmd/setup_test.go
• e2e/tests/setup/setup.go
• pkg/devcontainer/feature/extend.go
• pkg/devcontainer/feature/features.go
• pkg/devcontainer/feature/options.go

---

📝 Walkthrough

Walkthrough

This PR expands the setup command orchestration by promoting feature utility functions to public API, completely rewriting the setup flow to include container inspection, configuration loading, feature installation, and lifecycle hook execution, alongside comprehensive test coverage and end-to-end validation.

Changes

Setup Orchestration & Feature API

Layer / File(s)	Summary
Feature API Promotion pkg/devcontainer/feature/options.go, pkg/devcontainer/feature/features.go, pkg/devcontainer/feature/extend.go	Internal helper functions getFeatureEnvVariables and getFeatureInstallWrapperScript are renamed and exported as public functions GetFeatureEnvVariables and GetFeatureInstallWrapperScript. The extend.go callsites are updated to use the exported versions.
Setup Command Refactor cmd/setup.go	Major rewrite of the SetUpCmd structure and Run() method to orchestrate container inspection, devcontainer config loading and merging, feature resolution and installation, lifecycle hook execution, and JSON output emission. New imports added for copy utilities, config aliasing, and feature support. New DockerPath field added to struct. Multiple helper methods introduced: resolveDockerPath(), inspectRunningContainer(), loadConfig(), resolveWorkdir(), installFeatures(), resolveFeatureSets(), copyAndExecFeatures(), stageFeatures(), runSetUpLifecycleHooks(), plus utilities buildDockerExecArgs() and buildContainerEnvArgs(). New lifecycle hook identifiers (hookOnCreate, hookUpdateContent, hookPostCreate, hookPostStart, hookPostAttach) and flagSetUpDockerPath constant introduced.
Test Infrastructure cmd/setup_test.go	Two new test constants testCmdEcho and testCmdHello added.
Setup Command Unit Tests cmd/setup_test.go	Four new test functions added: TestNewSetUpCmd_DockerPathFlagOptional (verifies DockerPath flag behavior), TestBuildDockerExecArgs_NoWorkdir (validates docker exec args handling), TestSetUpCmd_ResolveDockerPath_Default and TestSetUpCmd_ResolveDockerPath_Custom (validate Docker path resolution logic).
End-to-End Tests e2e/tests/setup/setup.go	Six test blocks added to verify lifecycle command execution and feature installation: onCreateCommand, updateContentCommand, postAttachCommand, remoteEnv propagation to lifecycle commands, correct ordering of all lifecycle hooks, and installation of a local feature into the container.
Dependent Updates cmd/exec_test.go, cmd/runusercommands_test.go	cmd/exec_test.go refactored to use testCmdEcho and testCmdHello constants in two test functions. cmd/runusercommands_test.go has five hook-related test constants removed (now defined in setup.go).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• devsy-org/devsy#157: Introduced the exec command and its test infrastructure that the setup command now builds upon via shared test constants and docker path resolution patterns.
• devsy-org/devsy#197: Modifies devcontainer lifecycle hook execution order and feature hook behavior, directly related to the new lifecycle orchestration and feature staging logic in this PR.
• devsy-org/devsy#246: Updates cmd/runusercommands_test.go in parallel with this PR's cleanup of hook constants from that file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}