refactor(client): remove Log field from command option structs

[skevetter]

Summary

• Remove Log log.Logger field from CommandOptions and RunCommandOptions structs in workspace_client.go
• Replace logrus-based debug level check in RunCommand with pkg/log.DebugEnabled() package-level function
• Remove all Log: field assignments from callers across cmd/pro/, cmd/provider/use.go, pkg/workspace/list.go, and proxy_client.go
• Clean up unused oldlog imports where no other usage remains

Summary by CodeRabbit

• Refactor
  • Streamlined logging configuration across workspace, cluster, project, template, and provider operations to consolidate how logging is managed during command execution throughout the system.

[netlify]

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	c4e895c
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/69e74410767bcb0008c1025f

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5651ff05-e48a-44e7-83a3-4696ac6daaa4

📥 Commits

Reviewing files that changed from the base of the PR and between 6ae73ca and c4e895c.

📒 Files selected for processing (14)

• cmd/pro/check_health.go
• cmd/pro/create_workspace.go
• cmd/pro/list_clusters.go
• cmd/pro/list_projects.go
• cmd/pro/list_templates.go
• cmd/pro/list_workspaces.go
• cmd/pro/self.go
• cmd/pro/update_workspace.go
• cmd/pro/version.go
• cmd/pro/watch_workspaces.go
• cmd/provider/use.go
• pkg/client/clientimplementation/proxy_client.go
• pkg/client/clientimplementation/workspace_client.go
• pkg/workspace/list.go

💤 Files with no reviewable changes (13)

• cmd/pro/list_projects.go
• cmd/pro/list_workspaces.go
• cmd/pro/list_templates.go
• cmd/pro/update_workspace.go
• cmd/pro/list_clusters.go
• cmd/pro/version.go
• cmd/pro/self.go
• cmd/provider/use.go
• cmd/pro/create_workspace.go
• cmd/pro/watch_workspaces.go
• pkg/workspace/list.go
• pkg/client/clientimplementation/proxy_client.go
• cmd/pro/check_health.go

---

📝 Walkthrough

Walkthrough

This PR systematically removes explicit Log field parameters from RunCommandWithBinaries and related command execution calls across the codebase, refactoring from a pattern where loggers were injected per-command to relying on package-level logging defaults.

Changes

Cohort / File(s)	Summary
Pro commands (check/create/update/watch) cmd/pro/check_health.go, cmd/pro/create_workspace.go, cmd/pro/update_workspace.go, cmd/pro/watch_workspaces.go	Removed Log: oldlog.Default field from RunCommandWithBinariesCommandOptions.
Pro list/info commands cmd/pro/list_clusters.go, cmd/pro/list_projects.go, cmd/pro/list_templates.go, cmd/pro/list_workspaces.go, cmd/pro/self.go, cmd/pro/version.go	Removed oldlog import and deleted Log: oldlog.Default from RunCommandWithBinaries calls.
Provider command cmd/provider/use.go	Removed Log: oldlog.Default from initProvider call to RunCommandWithBinaries.
Client proxy and workspace pkg/client/clientimplementation/proxy_client.go, pkg/client/clientimplementation/workspace_client.go	Removed logger injection from command execution options; workspace_client.go replaced opts.Log debug-level check with devsylog.DebugEnabled() call and deleted unused Log fields from CommandOptions and RunCommandOptions structs.
Workspace list pkg/workspace/list.go	Removed Log: oldlog.Default from listInstancesProxyProvider call to RunCommandWithBinaries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor(log): migrate pkg/workspace, pkg/provider, pkg/daemon/agent to pkg/log #18: Broad refactor to remove injected oldlog.Logger parameters and stop forwarding opts.Log in RunCommandWithBinaries and CommandOptions.
• refactor(log): migrate agent, workspace, and utility packages to pkg/log #22: Performs the same logger plumbing refactor with matching changes to pkg/workspace and call sites, switching to pkg/log.
• refactor(log): migrate remaining cmd/ to pkg/log #15: Modifies the same logging wiring pattern—removing per-command Log instances and switching to package-level logging across cmd/* and client code.

Suggested labels

size/m

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring objective: removing the Log field from command option structs across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}