Uh oh!
There was an error while loading. Please reload this page.
fix(ci): resolve 3 desktop build failures in release workflow - #314
Conversation
- Point generate-pro-provider base_path to dist/ where arch-suffixed binaries are staged, and add PARTIAL=true as a safety net for any missing platform binaries - Add electron-vite build step before electron-builder so dist/main/index.js exists when packaging - Pin VS installation path via GYP_MSVS_OVERRIDE_PATH to prevent node-gyp stdout maxBuffer overflow during VS enumeration on Windows
✅ Deploy Preview for devsydev canceled.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow is updated to refine the desktop build and release pipeline. Provider generation now operates in partial mode with a revised input path, Windows builds gain explicit Visual Studio path detection, and an electron-vite build step is inserted before packaging. ChangesDesktop Release Workflow Build Pipeline
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes 3 pre-existing desktop build failures in the release workflow that were causing all desktop app builds (ubuntu, macOS, windows) to fail:
generate pro providerstep panicked because it looked for arch-suffixed binaries indesktop/resources/bin/(which only has the renameddevsybinary). Changed base_path todist/where arch-suffixed binaries are staged, and addedPARTIAL=trueas safety net for missing platform checksums.electron-builderfailed becausedist/main/index.jsdidn't exist. Added missingelectron-vite buildstep before electron-builder packaging.electron-rebuildduringnpm cifailed with node-gyp stdout maxBuffer overflow during VS enumeration. Addedvswhere.exeto pinGYP_MSVS_OVERRIDE_PATHdirectly, avoiding the enumeration.All 5 recent release runs showed identical failures. CLI binary builds were unaffected — only desktop builds failed.
Summary by CodeRabbit