Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): add confirmation dialogs for workspace rebuild and reset - #627
Conversation
Rebuild and Reset fired immediately with no explanation of their effects. Reset is destructive (removes the cloned source along with the container) yet had no warning, unlike the safer Delete and Rename actions which already confirm. Add ConfirmDialog prompts for both, matching the existing convention, with descriptions grounded in the CLI flag semantics (up --recreate vs up --reset).
✅ Deploy Preview for devsydev canceled.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Uh oh!
There was an error while loading. Please reload this page.
Summary
The Rebuild and Reset buttons on the workspace details page fired immediately with no explanation of their effects. Reset is destructive — the CLI
up --resetflag removes the cloned source code along with the container — yet it had no warning, unlike the safer Delete and Rename actions which already confirm.This adds
ConfirmDialogprompts for both actions, matching the existing convention, so users understand what each does before proceeding:up --recreate): non-destructive-styled dialog explaining it recreates the container from the devcontainer config, keeps source code, and loses only manual in-container changes.up --reset): destructive-styled dialog making clear the container and cloned source code are removed, so uncommitted/unpushed changes are permanently lost.Help text is grounded in the actual CLI flag semantics in
cmd/workspace/up/up_flags.go.