Uh oh!
There was an error while loading. Please reload this page.
chore: modernize stdlib usage via go fix - #7
Merged
Conversation
Adopt Go 1.23 stdlib idioms across the OpenAPI compiler and validate pass: maps.Collect/maps.Copy, slices.Contains/ContainsFunc/Sort, strings.SplitSeq, and integer range-over-int loops. Pure behavior-preserving cleanup with no functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the OpenAPI compiler and validate pass to use Go 1.23 standard-library
idioms, as surfaced by
go fix. No functional change — every rewrite is aone-to-one, behavior-preserving substitution:
maps.Collect/maps.Copyreplace manual map-building and map-copy loopsslices.Contains/slices.ContainsFunc/slices.Sortreplace hand-rolledmembership and sort loops
strings.SplitSeqreplacesstrings.Splitwhere the slice was only iteratedfor range Nreplacesfor i := 0; i < N; i++counters in testsNet −17 lines across 9 files, with the loops collapsing to clearer intent-revealing
calls.
Test plan
go build ./...,go vet ./...— cleango test ./...— all packages passgofmt -l— clean on tracked sourcegolangci-lint run ./compilers/... ./pass/...— 0 issues