chore(ui): Update TS libraries to @icp-sdk by raymondk · Pull Request #735 · dfinity/candid

raymondk · 2026-06-16T21:29:41Z

Update the candid ui cansiter to use the new TS libraries.

zeropath-ai · 2026-06-16T21:30:27Z

✅ No security or compliance issues detected. Reviewed everything up to c37342b.

Security Overview

🔎 Scanned files: 6 changed file(s)
🔗 Scan Link:https://zeropath.com/app/repositories/7ddf29dd-76dc-4f78-adfa-47ac8f4643e7?scanId=84724412-a6ad-432d-921e-dbe26f9f1b08&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Configuration changes	► tools/ui/package-lock.json Update @dfinity packages to @icp-sdk packages
Enhancement	► tools/ui/package-lock.json Update @dfinity packages to @icp-sdk packages

github-actions · 2026-06-16T21:34:53Z

Name	Max Mem (Kb)	Encode	Decode
blob	4_224	4_207_449	2_121_397
btreemap	75_456	529_878_266 ($\textcolor{red}{0.00\%}$)	10_166_634_693
double_option	128	1_323_089 ($\textcolor{red}{0.12\%}$)	27_197_905
large_variant	320	1_038_185 ($\textcolor{red}{0.09\%}$)	20_327_052
multi_arg	64	551_631 ($\textcolor{red}{0.02\%}$)	6_282_711
nns	192	1_992_456 ($\textcolor{red}{0.00\%}$)	5_514_215 ($\textcolor{red}{0.09\%}$)
nns_list_neurons	1_152	6_592_292 ($\textcolor{green}{-0.02\%}$)	210_714_588 ($\textcolor{red}{0.00\%}$)
nns_list_proposal	1_216	6_903_508 ($\textcolor{green}{-0.17\%}$)	55_076_799 ($\textcolor{red}{0.03\%}$)
option_list	128	727_821 ($\textcolor{red}{0.00\%}$)	16_423_653
result_variant	192	1_378_318 ($\textcolor{green}{-0.03\%}$)	16_140_430
subtype_decode	512	2_664_564 ($\textcolor{red}{0.02\%}$)	49_364_395 ($\textcolor{green}{-0.00\%}$)
text	6_336	4_204_305	7_877_258
variant_list	128	722_331 ($\textcolor{red}{0.00\%}$)	15_625_423
vec_int16	12_480	8_404_571	249_585_709
vec_nat	11_008	66_046_846	276_028_297
vec_nat32	24_768	16_793_179	243_294_534
vec_nat64	49_344	33_570_379	251_683_396
vec_service	64	687_601 ($\textcolor{green}{-0.17\%}$)	94_752_635 ($\textcolor{green}{-0.08\%}$)
wide_record	1_152	3_266_318 ($\textcolor{green}{-0.02\%}$)	44_558_022 ($\textcolor{green}{-0.00\%}$)

Parser cost: 15_587_601
Extra args: 2_861_924

Click to see raw report

---------------------------------------------------
Benchmark: blob
total:
instructions: 6.33 M (no change)
heap_increase: 66 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 4.21 M (no change)
heap_increase: 66 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 2.12 M (no change)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: btreemap
total:
instructions: 10.70 B (0.00%) (change within noise threshold)
heap_increase: 1179 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 529.88 M (0.00%) (change within noise threshold)
heap_increase: 159 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 10.17 B (no change)
heap_increase: 1020 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: double_option
total:
instructions: 28.52 M (0.01%) (change within noise threshold)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 1.32 M (0.12%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 27.20 M (no change)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: extra_args
total:
instructions: 2.86 M (no change)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: large_variant
total:
instructions: 21.37 M (0.00%) (change within noise threshold)
heap_increase: 5 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 1.04 M (0.09%) (change within noise threshold)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 20.33 M (no change)
heap_increase: 3 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: multi_arg
total:
instructions: 6.84 M (0.00%) (change within noise threshold)
heap_increase: 1 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 551.63 K (0.02%) (change within noise threshold)
heap_increase: 1 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 6.28 M (no change)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: nns
total:
instructions: 23.93 M (0.02%) (change within noise threshold)
heap_increase: 3 pages (no change)
stable_memory_increase: 0 pages (no change)
0. Parsing (scope):
calls: 1 (no change)
instructions: 15.59 M (no change)
heap_increase: 3 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 1.99 M (0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 5.51 M (0.09%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: nns_list_neurons
total:
instructions: 217.31 M (-0.00%) (change within noise threshold)
heap_increase: 18 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 6.59 M (-0.02%) (change within noise threshold)
heap_increase: 18 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 210.71 M (0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: nns_list_proposal
total:
instructions: 61.98 M (0.00%) (change within noise threshold)
heap_increase: 19 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 6.90 M (-0.17%) (change within noise threshold)
heap_increase: 5 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 55.08 M (0.03%) (change within noise threshold)
heap_increase: 14 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: option_list
total:
instructions: 17.15 M (0.00%) (change within noise threshold)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 727.82 K (0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 16.42 M (no change)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: result_variant
total:
instructions: 17.52 M (-0.00%) (change within noise threshold)
heap_increase: 3 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 1.38 M (-0.03%) (change within noise threshold)
heap_increase: 1 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 16.14 M (no change)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: subtype_decode
total:
instructions: 52.03 M (0.00%) (change within noise threshold)
heap_increase: 8 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 2.66 M (0.02%) (change within noise threshold)
heap_increase: 8 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 49.36 M (-0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: text
total:
instructions: 12.08 M (no change)
heap_increase: 99 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 4.20 M (no change)
heap_increase: 66 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 7.88 M (no change)
heap_increase: 33 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: variant_list
total:
instructions: 16.35 M (0.00%) (change within noise threshold)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 722.33 K (0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 15.63 M (no change)
heap_increase: 2 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: vec_int16
total:
instructions: 257.99 M (no change)
heap_increase: 195 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 8.40 M (no change)
heap_increase: 130 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 249.59 M (no change)
heap_increase: 65 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: vec_nat
total:
instructions: 342.08 M (no change)
heap_increase: 172 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 66.05 M (no change)
heap_increase: 33 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 276.03 M (no change)
heap_increase: 139 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: vec_nat32
total:
instructions: 260.09 M (no change)
heap_increase: 387 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 16.79 M (no change)
heap_increase: 258 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 243.29 M (no change)
heap_increase: 129 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: vec_nat64
total:
instructions: 285.26 M (no change)
heap_increase: 771 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 33.57 M (no change)
heap_increase: 514 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 251.68 M (no change)
heap_increase: 257 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: vec_service
total:
instructions: 95.44 M (-0.08%) (change within noise threshold)
heap_increase: 1 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 687.60 K (-0.17%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 94.75 M (-0.08%) (change within noise threshold)
heap_increase: 1 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Benchmark: wide_record
total:
instructions: 47.83 M (-0.00%) (change within noise threshold)
heap_increase: 18 pages (no change)
stable_memory_increase: 0 pages (no change)
1. Encoding (scope):
calls: 1 (no change)
instructions: 3.27 M (-0.02%) (change within noise threshold)
heap_increase: 18 pages (no change)
stable_memory_increase: 0 pages (no change)
2. Decoding (scope):
calls: 1 (no change)
instructions: 44.56 M (-0.00%) (change within noise threshold)
heap_increase: 0 pages (no change)
stable_memory_increase: 0 pages (no change)
---------------------------------------------------
Summary:
instructions:
status: No significant changes 👍
counts: [total 20 | regressed 0 | improved 0 | new 0 | unchanged 20]
change: [max +5.07K | p75 +192 | median 0 | p25 0 | min -81.16K]
change %: [max +0.02% | p75 0.00% | median 0.00% | p25 0.00% | min -0.08%]
heap_increase:
status: No significant changes 👍
counts: [total 20 | regressed 0 | improved 0 | new 0 | unchanged 20]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 20 | regressed 0 | improved 0 | new 0 | unchanged 20]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Successfully persisted results to canbench_results.yml

Update after: This is to be updated after #735 is merged There's a been a "temporary hack" since 2022 - I spot checked canisters and they seem to have the standard "candid:service" metadata, eg: ``` # bitcoin minter icp canister metadata -n ic mqygn-kiaaa-aaaar-qaadq-cai "candid:service" ```

chore(ui): Update TS libraries to @icp-sdk
49def3c

raymondk requested a review from a team as a code owner June 16, 2026 21:29

raymondk mentioned this pull request Jun 16, 2026
feat(ui): use candid:service metadata to lookup did #736
Merged

use ic-management
c37342b

lwshang approved these changes Jun 17, 2026
View reviewed changes

raymondk merged commit ac2ef66 into masterJun 17, 2026
11 checks passed

raymondk deleted the rk/02-remove-dfinity-libs branch June 17, 2026 15:05

Navigation Menu

Uh oh!

chore(ui): Update TS libraries to @icp-sdk - #735

chore(ui): Update TS libraries to @icp-sdk#735
raymondk merged 2 commits into
masterfrom
rk/02-remove-dfinity-libs

raymondk commented Jun 16, 2026

Uh oh!

zeropath-aiBot commented Jun 16, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jun 16, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

raymondk commented Jun 16, 2026

Uh oh!

zeropath-aiBot commented Jun 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jun 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zeropath-aiBot commented Jun 16, 2026•
edited
Loading

github-actionsBot commented Jun 16, 2026•
edited
Loading