Improve cancel - #18
Merged
Merged
Conversation
Master and docking branch both work.
Otherwise the compiler complains that they have been "declared ‘static’ but never defined" in user code.
Mostly int/size_t mismatches.
- top bar isn't cut off anymore if a larger font is used (i.e, 48 points for high-dpi displays) - button sizes for Open/Save and Cancel in the bottom bar now also depend on the font size - the frame inset at the bottom frame border now has the same size as for the other borders (it was slightly too big before)
Open
dfranx
commented
Dec 6, 2021
Owner
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #17.
This improves the behavior of the Cancel function. Previously, when pressing the Cancel button in the bottom bar, a path was returned via
HasResult()if the dialog type wasIFD_DIALOG_DIRECTORY, the same as whenOpenwas pressed.Also the ESCAPE key can now be pressed to cancel the dialog.