Pin line endings to LF - #25
Merged
Merged
Conversation
core.autocrlf is a machine setting and does not travel with the repo. With it off and no .gitattributes, git normalises nothing and whatever bytes the editor wrote get committed verbatim. This makes the rule part of the repo instead.
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the sweep in dhanjit/brain#133. Adds the same
.gitattributesevery other repo now carries:core.autocrlfis a machine setting and does not travel with a clone; this does. Without it git normalises nothing and whatever bytes the editor wrote get committed verbatim.No renormalisation is needed here — the 29 CRLF blobs this repo used to hold were all under
node_modules/, and 43c75e3 already removed that from tracking. Every remaining blob onmasteris LF.This is a PR rather than a direct push because
masterrequires one. Note the branch rule also requires verified signatures, and this commit will show as Unverified: the SSH signing key in~/.gitconfig(user.signingkey = ~/.ssh/id_ed25519.pub,gpg.format = ssh) is not registered on the GitHub account as a signing key, so the API reportsunknown_key. That affects every locally-signed commit, not just this one. Adding the public key under Settings → SSH and GPG keys → New SSH key with key type Signing Key fixes it retroactively for commits already pushed.