Uh oh!
There was an error while loading. Please reload this page.
Add Python 3.13 support - #139
Open
vlogic wants to merge 1 commit into
Open
Conversation
- Replace pkg_resources with importlib.metadata + packaging in liccheck/requirements.py and command_line.py. A Python 3.13 venv created the normal way has no setuptools, so pkg_resources was unimportable and `liccheck` crashed immediately after install. This removes the dependency on it entirely instead of papering over it with a setuptools pin. - Keep pip._internal for requirements.txt parsing (still resolves fine against current pip; the only pip-free alternative library is stale and has an open bug against current packaging releases). Drop the dead pip<10 fallback import branches. - Add `packaging` as a runtime dependency. - Raise python_requires to >=3.8 and update classifiers (3.8-3.13). - Add Python 3.12/3.13 to the CI matrix and tox envlist; drop the already-unsupported py35-py37 tox entries. - Authorize Apache-2.0 in liccheck.ini for packaging's own license. - Update tests: rewrite pkg_resources-based fixtures with importlib.metadata.PathDistribution, and adjust expected package counts for the new packaging dependency. Verified on real Python 3.10-3.13 interpreters, including a clean 3.13 venv with no setuptools preinstalled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Python 3.13 support
liccheck/requirements.py and command_line.py. A Python 3.13 venv
created the normal way has no setuptools, so pkg_resources was
unimportable and
liccheckcrashed immediately after install.This removes the dependency on it entirely instead of papering
over it with a setuptools pin.
fine against current pip; the only pip-free alternative library
is stale and has an open bug against current packaging releases).
Drop the dead pip<10 fallback import branches.
packagingas a runtime dependency.already-unsupported py35-py37 tox entries.
importlib.metadata.PathDistribution, and adjust expected package
counts for the new packaging dependency.
Verified on real Python 3.10-3.13 interpreters, including a clean
3.13 venv with no setuptools preinstalled.