Skip to content

[OPTIONAL] Add a note about OSX locales and pipenv - #7

Open
Harish Navnit (tinvaan) wants to merge 1 commit into
dialpad:masterfrom
tinvaan:readme/note
Open

[OPTIONAL] Add a note about OSX locales and pipenv#7
Harish Navnit (tinvaan) wants to merge 1 commit into
dialpad:masterfrom
tinvaan:readme/note

Conversation

@tinvaan

@tinvaanHarish Navnit (tinvaan) commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

Just a small note for first time users to follow along.

@bendialpad

bendialpad commented Feb 16, 2022

Copy link
Copy Markdown

I'm not sure if we should be adding external library-specific notes here since there's most likely a long list of gotchas with those libraries that can be found on their respective repos. Jake Nielsen (@jakedialpad) any thoughts?

@tinvaan

Harish Navnit (tinvaan) commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm not sure if we should be adding external library-specific notes here since there's most likely a long list of gotchas with those libraries that can be found on their respective repos. Jake Nielsen (@jakedialpad) any thoughts?

Agree. However, this particular issue seemed more platform specific than library specific. Either way, it's not a make or break change. Fine by me either way.

@tinvaanHarish Navnit (tinvaan) changed the title Add a note about OSX locales and pipenv[OPTIONAL] Add a note about OSX locales and pipenvFeb 16, 2022
jakedialpad
Jake Nielsen (jakedialpad) approved these changes Mar 1, 2022
View reviewed changes

@jakedialpadJake Nielsen (jakedialpad) left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, FWIW I'm all for highlighting common gotchas 👍

If it's a super rare issue then we might just be adding extra noise, but this seems like a good one to me ¯\_(ツ)_/¯

Comment threadREADME.md

That was easy :)

<b>NOTE</b>: If you're on OSX, you may need to set the LOCALE's explcitly before running the `pipenv install` command.

@jakedialpadJake Nielsen (jakedialpad)Mar 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a little typo: explcitly -> explicitly
:p

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jakedialpadJake Nielsen (jakedialpad)jakedialpad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tinvaan@bendialpad@jakedialpad