Skip to content

Diem ID Payment in Miniwallet with E2E Test - #309

Merged
sunmilee merged 5 commits into
diem:masterfrom
sunmilee:diemid
Jun 28, 2021
Merged

Diem ID Payment in Miniwallet with E2E Test#309
sunmilee merged 5 commits into
diem:masterfrom
sunmilee:diemid

Conversation

@sunmilee

@sunmileesunmilee commented Jun 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds functionality to send and receive payments using DiemID as the account identifier, with a full E2E test. Things to note:

  • Created a new ReferenceID storage model to check for duplicate reference ID
  • "payee" in txn can now be either diem ID or bech 32 address
  • Internal transaction with diem ID is not handled

Continuation from: #306

@sunmileesunmilee changed the title Add e2e testDiem ID Payment in Miniwallet with E2E TestJun 22, 2021
@sunmilee
sunmilee requested a review from xliJune 22, 2021 02:19
@sunmileesunmilee mentioned this pull request Jun 22, 2021
Open
24 tasks
@sunmileesunmilee linked an issue Jun 22, 2021 that may be closed by this pull request
Diem ID #291
Open
24 tasks
xli
xli reviewed Jun 22, 2021
View reviewed changes
Comment threadsrc/diem/identifier/diem_id.py
Comment threadsrc/diem/identifier/diem_id.py Outdated
Comment threadsrc/diem/identifier/diem_id.py
Comment threadsrc/diem/identifier/diem_id.py
Comment threadsrc/diem/testing/miniwallet/app/app.py
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py Outdated
@sunmilee
sunmilee requested a review from xliJune 24, 2021 08:35
xli
xli reviewed Jun 24, 2021
View reviewed changes
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/app.py
xli
xli reviewed Jun 24, 2021
View reviewed changes
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
@sunmilee
sunmilee requested a review from xliJune 28, 2021 19:18
xli
xli approved these changes Jun 28, 2021
View reviewed changes
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py Outdated
Comment threadsrc/diem/testing/miniwallet/app/offchain_api_v2.py
Comment threadsrc/diem/testing/miniwallet/app/app.py Outdated
xli
xli approved these changes Jun 28, 2021
View reviewed changes
@sunmilee
sunmilee merged commit 6ff2f1f into diem:masterJun 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xlixlixli approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Diem ID

2 participants

@sunmilee@xli