Skip to content

Array speedup - #1874

Closed
tautschnig wants to merge 6 commits into
developfrom
array-speedup
Closed

Array speedup#1874
tautschnig wants to merge 6 commits into
developfrom
array-speedup

Conversation

@tautschnig

@tautschnigtautschnig commented Feb 22, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.h Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp
return false;
}

void arrayst::weg_path_condition(

@romainbrenguierromainbrenguierFeb 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be documented

@romainbrenguierromainbrenguierFeb 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a verb in the function name is generally clearer

romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp Outdated
romainbrenguier
romainbrenguier reviewed Feb 23, 2018
View reviewed changes
Comment threadsrc/solvers/flattening/arrays.cpp
@martin-cs

martin-cs commented Mar 1, 2018

Copy link
Copy Markdown
Collaborator

@tautschnig shout when you want a review from me.

@tautschnigtautschnig mentioned this pull request Apr 24, 2018
Closed
@tautschnigtautschnig mentioned this pull request Jun 11, 2018
Merged
@tautschnigtautschnig mentioned this pull request Jan 16, 2021
Open
@TGWDB

TGWDB commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

@tautschnig This PR is still waiting on some changes to address reviewer comments (and now a rebase). Is there a plan to progress on this PR since it is mentioned in others?

@tautschnig

tautschnig commented Feb 23, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@tautschnig This PR is still waiting on some changes to address reviewer comments (and now a rebase). Is there a plan to progress on this PR since it is mentioned in others?

Yes, this is on my pile of TODOs. In terms of performance, it's probably one of the most urgent to work on. Just trying to address the soundness-related ones first.

@martin-cs

martin-cs commented Feb 24, 2021

Copy link
Copy Markdown
Collaborator

@tautschnig : Trevor and I have been having some issues with the current array code and may need to look at it in the next few months. Reviewing this / getting it merged might well help us with that.

@tautschnigtautschnig mentioned this pull request May 19, 2021
Closed
@tautschnig
Use instantiate() when flattening array_comprehension_exprt
a2a4feb
Uses the capabilities of binding_exprt instead of relying on the
unrelated replace_exprt to do the right thing.
tautschnigand others added 5 commits April 24, 2022 16:10
@tautschnig
Failing test to demonstrate need for extensionality rule
6f2263a
All existing tests rely on indexed access to arrays, which is covered by
the read-over-write axiom.
@tautschnig
Flattening: support index expressions over zero bitwidth arrays
b2589d4
There is not really anything wrong in having empty bitvectors, which we
otherwise already support (as of e021eef).
@tautschnig
Test trace-values: create reads to enforce instantiation
ecfb7ae
The test specification expects that the indices 0, 1, and one other are
instantiated. The array theory is only required to do so when also
reading from these elements.
@kroening@tautschnig
performance tests for reading/writing arrays
2178a2f
@kroening@tautschnig
Array theory: implement weakly equivalent arrays
a02b480
This implements Christ and Hoenicke's Weakly Equivalent Arrays
(https://arxiv.org/pdf/1405.6939.pdf) with in-place depth-first path
enumeration.
Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
@tautschnig
tautschnig dismissed romainbrenguier’s stale reviewApril 24, 2022 19:23

Code has now largely been rewritten.

@tautschnig
tautschnig marked this pull request as draft April 24, 2022 19:50
@tautschnigtautschnig self-assigned this Apr 24, 2022
@tautschnigtautschnig mentioned this pull request Jul 14, 2022
Open
@TGWDB

TGWDB commented May 3, 2023

Copy link
Copy Markdown
Contributor

Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work.

@TGWDBTGWDB closed this May 3, 2023
@tautschnigtautschnig mentioned this pull request Jul 2, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisr-diffbluechrisr-diffblueAwaiting requested review from chrisr-diffblue
@kroeningkroeningAwaiting requested review from kroeningkroening is a code owner
@martin-csmartin-csAwaiting requested review from martin-csmartin-cs is a code owner
@peterschrammelpeterschrammelAwaiting requested review from peterschrammelpeterschrammel is a code owner
@smowtonsmowtonAwaiting requested review from smowton
@chris-ryderchris-ryderAwaiting requested review from chris-ryder
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review
1 more reviewer
@romainbrenguierromainbrenguierromainbrenguier left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tautschnigtautschnig

@kroeningkroening

Labels

Array Theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tautschnig@martin-cs@TGWDB@romainbrenguier@kroening