Skip to content

Ensure typet constructor is always compatible with GCC 5's STL [blocks: #4458] - #4460

Merged
tautschnig merged 1 commit into
diffblue:developfrom
tautschnig:constructor-fix
Mar 30, 2019
Merged

Ensure typet constructor is always compatible with GCC 5's STL [blocks: #4458]#4460
tautschnig merged 1 commit into
diffblue:developfrom
tautschnig:constructor-fix

Conversation

@tautschnig

Copy link
Copy Markdown
Collaborator

When enabling NAMED_SUB_IS_FORWARD_LIST, compilation failed as the
std::forward_list constructors shipped with GCC 5 do not support an
empty initializer list. GCC 6 and later do not have any such problem.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnigtautschnig changed the title Ensure typet constructor is always compatible with GCC 5's STLEnsure typet constructor is always compatible with GCC 5's STL [blocks: #4458]Mar 30, 2019
Comment threadsrc/util/type.h
: irept(std::move(_id), {}, {std::move(_subtype)})
{
}
#else

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this will also be used under Clang, which pretends to be gcc 4.2.1

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks a lot, I've added #defined(__clang__) to the above #if.

When enabling NAMED_SUB_IS_FORWARD_LIST, compilation failed as the
std::forward_list constructors shipped with GCC 5 do not support an
empty initializer list. GCC 6 and later do not have any such problem.
@tautschnigtautschnig self-assigned this Mar 30, 2019
@tautschnig
tautschnig merged commit d460249 into diffblue:developMar 30, 2019
@tautschnig
tautschnig deleted the constructor-fix branch March 30, 2019 12:35

@allredjallredj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: ca155d3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106425825

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tautschnig@smowton@allredj