Uh oh!
There was an error while loading. Please reload this page.
Cleanups in loading of jar files - #4698
Conversation
smowton
left a comment
There was a problem hiding this comment.
I suspect you'll be asked to remove extract-to-file because it's unused
| return { buffer.cbegin(), null_char_it }; | ||
| const auto id = static_cast<mz_uint>(index); | ||
| mz_uint name_size = mz_zip_reader_get_filename(m_state.get(), id, nullptr, 0); | ||
| if(name_size == 0) |
| { | ||
| const auto id = static_cast<mz_uint>(index); | ||
| mz_zip_archive_file_stat file_stat; | ||
| if(mz_zip_reader_file_stat(m_state.get(), id, &file_stat) != MZ_TRUE) |
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 31cfb2a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112922881
31cfb2a to
754eba5CompareNathanJPhillips
commented
May 23, 2019
@smowton - happy to remove extract-to-file if you'd like - although there are other bits of functionality in JBMC that are only used by derivative projects. We can keep it for ourselves but it seemed like it might be useful to expose it for other potential users. |
smowton
left a comment
There was a problem hiding this comment.
I'm happy with this as-is, just noting a common complaint re: committing untested / unused code :)
| throw std::runtime_error("Could not extract the file"); | ||
| } | ||
| void mz_zip_archivet::extract_to_file( |
There was a problem hiding this comment.
That doesn't seem to match the PR title.
| const auto id = static_cast<mz_uint>(index); | ||
| mz_uint name_size = mz_zip_reader_get_filename(m_state.get(), id, nullptr, 0); | ||
| if(name_size == 0) | ||
| return {}; // Failure |
There was a problem hiding this comment.
@NathanJPhillips clang-format would like to see one space removed.
e76f912 to
ba7b35aComparetautschnig
commented
May 30, 2019
@NathanJPhillips Please rebase now that #4729 is in to make CI happy. |
ba7b35a to
6b5dfb1Compareallredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 6b5dfb1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113796715
This can be used to extract nested jar files to a temporary folder.
6b5dfb1 to
72936d1Comparecodecov-io
commented
May 31, 2019
Codecov Report
@@ Coverage Diff @@## develop #4698 +/- ##
==========================================
Coverage ? 68.44% ==========================================
Files ? 1255 Lines ? 104099 Branches ? 0 ==========================================
Hits ? 71250 Misses ? 32849 Partials ? 0
Continue to review full report at Codecov.
|
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 72936d1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113895476
This includes adding a wrapper for the extract to file functionality to complement the extract to memory wrapper.