Uh oh!
There was an error while loading. Please reload this page.
Conversation
nedtwigg
left a comment
There was a problem hiding this comment.
Great, thanks a lot! I think the default behavior here is too risky, we can either gate this risky behavior behind a flag, or we can force users to make sure their SSH known_hosts stuff is accurate.
Uh oh!
There was an error while loading. Please reload this page.
nedtwigg
left a comment
There was a problem hiding this comment.
Sorry I didn't think to suggest this earlier, but it jumped out at me as I looked at the new commits. There might be other SSH properties that users want to override in the future, and that will be easier if we have a consistent mapping.
I think the whole thing gets a bit simpler if we do this rename:
boolean sshDisableStrictHostKeyChecking = false;
String sshStrictHostKeyChecking = "yes";
That way we can automatically support any other String modes that SSH might have someday, and it's a consistent way to override whichever ssh config properties we add support for in the future.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nedtwigg
commented
Mar 30, 2021
Published in |
this can resolve#19, but actually the StrictHostKeyChecking property is set to 'no'