Skip to content

Feature/ssh - #20

Merged
nedtwigg merged 7 commits into
mainfrom
unknown repository
Mar 30, 2021
Merged

Feature/ssh#20
nedtwigg merged 7 commits into
mainfrom
unknown repository

Conversation

@christianaye

Copy link
Copy Markdown
Contributor

this can resolve#19, but actually the StrictHostKeyChecking property is set to 'no'

@nedtwiggnedtwigg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! I think the default behavior here is too risky, we can either gate this risky behavior behind a flag, or we can force users to make sure their SSH known_hosts stuff is accurate.

@nedtwiggnedtwigg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't think to suggest this earlier, but it jumped out at me as I looked at the new commits. There might be other SSH properties that users want to override in the future, and that will be easier if we have a consistent mapping.

I think the whole thing gets a bit simpler if we do this rename:

boolean sshDisableStrictHostKeyChecking = false;
String sshStrictHostKeyChecking = "yes";

That way we can automatically support any other String modes that SSH might have someday, and it's a consistent way to override whichever ssh config properties we add support for in the future.

Comment threadREADME.md Outdated
@nedtwigg
nedtwigg merged commit e0458df into diffplug:mainMar 30, 2021
@nedtwigg

Copy link
Copy Markdown
Member

Published in 2.1.0

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support SSH URLs for changelogPush

2 participants

@christianaye@nedtwigg