Skip to content

Removed system line separator change from eclipse-base config - #1058

Closed
fvgh wants to merge 1 commit into
mainfrom
no-system-change-per-default
Closed

Removed system line separator change from eclipse-base config#1058
fvgh wants to merge 1 commit into
mainfrom
no-system-change-per-default

Conversation

@fvgh

@fvghfvgh commented Dec 31, 2021

Copy link
Copy Markdown
Member
  • changeSystemLineSeparator no longer part of default configuration
  • Added annotations due to spotbugs version bump

As agreed for #1049, the line separator config will no longer be part of the default configuration.
First tests shows that the System line separator is currently only used by WTP.
Tests for the different formatters will be provided in dedicated PR.

@fvgh
fvgh requested a review from nedtwiggDecember 31, 2021 12:05
@fvgh

fvgh commented Dec 31, 2021

Copy link
Copy Markdown
MemberAuthor

@nedtwigg As clarified in #1054, the tests are not executed for eclipse-base by CI. I made some changes to the tests due to the spotbugs version upgrade. What is the best way to enable the tests in CI, and to executed them on a bug/feature branch?

- changeSystemLineSeparator no longer part of default configuration
- Added annotations due to spotbugs version bump
@fvgh
fvghforce-pushed the no-system-change-per-default branch from 7bad837 to 95533ddCompareDecember 31, 2021 12:23
@nedtwigg
nedtwigg changed the base branch from main-temp to mainApril 20, 2022 21:30
@nedtwigg

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fvgh@nedtwigg