Skip to content

Add cleanthat to spotless config - #1578

Closed
blacelle wants to merge 4 commits into
diffplug:mainfrom
blacelle:EnforceVar_jdk11
Closed

Add cleanthat to spotless config#1578
blacelle wants to merge 4 commits into
diffplug:mainfrom
blacelle:EnforceVar_jdk11

Conversation

@blacelle

Copy link
Copy Markdown
Contributor

This refers to #1532, considering var usage enforcement.

It does not implement unless the line has a comment part of the spec. I wonder how much this is a strict requirement. (Also, does it include comment before the variable declaration ? What if the variable declaration stands on multiple rows?)

This fails with spotless-gradle 6.15.0 ; the fix is pending for next spotless-gradle release.

@blacelle
blacelle marked this pull request as ready for review March 7, 2023 06:49
@blacelleblacelle mentioned this pull request Mar 7, 2023
@blacelle

Copy link
Copy Markdown
ContributorAuthor

@nedtwigg This has been resynced with main. Ready-for-merging

@nedtwigg

Copy link
Copy Markdown
Member

I am eager to add cleanthat to our code style. But change in our code style will cause merge conflicts, so this PR is also blocked on

@nedtwiggnedtwigg added the pr-archive PRs which are still valid but have gotten stuck for some reason label Feb 12, 2024
@nedtwigg

Copy link
Copy Markdown
Member

We no longer have any long-lived PRs blocking an effort of this type. Feel free to submit again if you're still interested.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-archivePRs which are still valid but have gotten stuck for some reason

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@blacelle@nedtwigg